reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1827) new Uri(path) in REEF.NET IO Returns Lowercase String
Date Wed, 06 Jun 2018 13:56:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503329#comment-16503329
] 

ASF GitHub Bot commented on REEF-1827:
--------------------------------------

markusweimer commented on issue #1433: [REEF-1827] new Uri(path) in REEF.NET IO Returns Lowercase
String
URL: https://github.com/apache/reef/pull/1433#issuecomment-395077147
 
 
   Closing this for lack of updates.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> new Uri(path) in REEF.NET IO Returns Lowercase String
> -----------------------------------------------------
>
>                 Key: REEF-1827
>                 URL: https://issues.apache.org/jira/browse/REEF-1827
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF.NET IO
>    Affects Versions: 0.15
>            Reporter: Shouheng Yi
>            Priority: Minor
>              Labels: security
>
> In the [Org.Apache.REEF.IO.FileSystem.IFileSystem|https://github.com/apache/reef/blob/3531944f11cc115b105a6bec4268713766425034/lang/cs/Org.Apache.REEF.IO/FileSystem/IFileSystem.cs],
we have many methods that are based on C#'s Uri. For example:
> {code:none}
> void CopyToLocal(Uri remoteFileUri, string localName);
> void CreateDirectory(Uri directoryUri);
> ...
> {code}
> From the logging and my experiments, this converts path to lowercase characters. For
example:
> {code:none}
> new Uri("hdfs://XYZ123/mypath/data.txt") // Returns "hdfs://xyz123/mypath/data.txt"
> {code}
> If we are interacting with hdfs, in the subsequent dfs command in [Org.Apache.REEF.IO.FileSystem.Hadoop|https://github.com/apache/reef/blob/3531944f11cc115b105a6bec4268713766425034/lang/cs/Org.Apache.REEF.IO/FileSystem/Hadoop/HadoopFileSystem.cs]:
> {code:none}
> public void CopyToLocal(Uri remoteFileUri, string localName)
> {
>     _commandRunner.Run("dfs -get " + remoteFileUri + " " + localName);
> }
> {code}
> this will fail, since hdfs is case-sensitive. I'm wondering if we are open to the idea
of having some string based APIs that ensure users that they are passing the exact path as
they specified in their code. Thanks!
> Here is the link to the PR: [#1329|https://github.com/apache/reef/pull/1329]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message