reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 송원욱 <won...@apache.org>
Subject Re: Committer guide updated
Date Tue, 12 Jun 2018 18:07:24 GMT
Sure, I've added the part that you're concerned with by adding appropriate
screenshots on the 'Merge changes' subsection on the site
<https://cwiki.apache.org/confluence/display/REEF/Accepting+Pull+Requests>
Wonook


2018년 6월 12일 (화) 오후 7:31, Byung-Gon Chun <bgchun@gmail.com>님이 작성:

> Wonook, if we just merge a PR, the commit message in the gitbox repo
> history is not what we want.
> https://gitbox.apache.org/repos/asf?p=reef.git
> Note that the last commit message is "Merge pull request #1475 from
> DifferentSC/REEF-2019".
>
> Did you discuss this issue in the guide?
>
> Thanks.
> -Gon
>
>
> On Tue, Jun 12, 2018 at 7:52 AM, Byung-Gon Chun <bgchun@gmail.com> wrote:
>
> > Hi,
> >
> > Wonook updated the committer guide to accept PRs. Thanks, Wonook!
> > https://cwiki.apache.org/confluence/display/REEF/Accepting+Pull+Requests
> >
> > As you can see, it's much simpler than the old guide. :)
> > Take a look. If you'd like to update it, please feel free to do.
> >
> > Cheers,
> > Gon
> >
> > --
> > Byung-Gon Chun
> >
>
>
>
> --
> Byung-Gon Chun
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message