reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chenxi Zhao <Chenxi.Z...@microsoft.com.INVALID>
Subject RE: [REEF-1963] reef-bridge-client jar is added to local files instead of global files
Date Mon, 12 Mar 2018 21:40:29 GMT
Thanks for clarification Markus. I will add it.

Chenxi

-----Original Message-----
From: Markus Weimer <markus@weimo.de> 
Sent: Monday, March 12, 2018 2:27 PM
To: REEF Developers Mailinglist <dev@reef.apache.org>
Subject: Re: [REEF-1963] reef-bridge-client jar is added to local files instead of global
files

On Mon, Mar 12, 2018 at 2:06 PM, Chenxi Zhao < Chenxi.Zhao@microsoft.com.invalid> wrote:

> Hi,
>
> I found a problem in existing code - there is an inconsistency between 
> the code and comments in the patch of [REEF-1963].
>
> This code is here:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fapache%2Freef%2Fpull%2F1419%2Ffiles%23diff-&data=04%7C01%7CChe
> nxi.Zhao%40microsoft.com%7Cc4cd5a12c63b4a107c7908d5886014a5%7C72f988bf
> 86f141af91ab2d7cd011db47%7C1%7C0%7C636564868606152285%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7
> C-1&sdata=AGdDNJ5WCwp6QCazs03M%2Br3r6LsUvt2fhDkzHYCEJm8%3D&reserved=0
> efdd11540e9df2901a6805761a41acb5R94
>
> The comments say reef-bridge-client jar is going to be added in global 
> files, as well as the Jira ticket says 
> (https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissu
> es.apache.org%2F&data=04%7C01%7CChenxi.Zhao%40microsoft.com%7Cc4cd5a12
> c63b4a107c7908d5886014a5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
> 636564868606152285%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo
> iV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=RhziM00Brn9A2yW%2BoylsmA7
> kcUM7IqysXysYKROa%2BaI%3D&reserved=0
> jira/browse/REEF-1963) but actually it is adding to local files.
>
> Any comments?
>

Thanks for reporting this. If the JAR is actually added to the *local* files by the code,
the code is right.

Background: Local files are only copied to the Driver, Global files to all Evaluators. The
bridge JAR is only needed on the Driver.

Next steps: Can you please leave a commend of REEF-1963 with your finding?
That is the most likely place people would look for information on the discrepancy, followed
by this list.

Thanks!

Markus
Mime
View raw message