reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1949) Closing ThreadPoolStage before tasks are finished
Date Mon, 06 Nov 2017 00:02:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239778#comment-16239778
] 

Markus Weimer commented on REEF-1949:
-------------------------------------

This could be another instance where the locking in the bridge creates a bottleneck. [~juliaw],
what do you think?

> Closing ThreadPoolStage before tasks are finished
> -------------------------------------------------
>
>                 Key: REEF-1949
>                 URL: https://issues.apache.org/jira/browse/REEF-1949
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF Driver
>    Affects Versions: 0.17
>            Reporter: Pei Jiang
>
> In EvaluatorManager.onEvaluatorDone(),
> {code}
> // This relies on the dispatcher to call the CompletedEvaluator handler.
> this.messageDispatcher.onEvaluatorCompleted(new CompletedEvaluatorImpl(this.evaluatorId));

> // This will close the dispatcher, which in turns shut down the executor in ThreadPoolStage.
> this.close(); 
> {code}
> Since in onEvaluatorCompleted the message sending task is submitted to an executor, there
is no guarantee that the CompletedEvaluator message will be sent before the termination of
the executor in this.close() call. When this happens, the CompletedEvaluator handler will
not be triggered so the driver will think that some evaluators are alive and hence hang.
> Relevant logs:
> {code}
> Nov 01, 2017 11:05:57 PM org.apache.reef.wake.impl.ThreadPoolStage close
> SEVERE: Closing ThreadPoolStage EvaluatorMessageDispatcher:container_1508975419755_0006_01_000004:
Executor did not terminate in 1,000 ms. Dropping 2 tasks
> Nov 01, 2017 11:05:57 PM org.apache.reef.wake.impl.ThreadPoolStage close
> SEVERE: Closing ThreadPoolStage EvaluatorMessageDispatcher:container_1508975419755_0006_01_000004:
Executor failed to terminate.
> End of LogType:driver.stderr
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message