reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergiy Matusevych (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (REEF-1909) Broken master: Compilation errors in VSC++ 2013 and 2015
Date Mon, 23 Oct 2017 08:44:00 GMT

     [ https://issues.apache.org/jira/browse/REEF-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sergiy Matusevych closed REEF-1909.
-----------------------------------
    Resolution: Fixed

Fixed in PR [#1398|https://github.com/apache/reef/pull/1398]

> Broken master: Compilation errors in VSC++ 2013 and 2015
> --------------------------------------------------------
>
>                 Key: REEF-1909
>                 URL: https://issues.apache.org/jira/browse/REEF-1909
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF Bridge
>            Reporter: Sergiy Matusevych
>            Assignee: Julia
>            Priority: Critical
>              Labels: build-failure, c++, managed
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Our current master branch fails to compile with Visual Studio 2013 and 2015, giving the
following error:
> {code:none}
> "C:\projects\reef\lang\cs\Org.Apache.REEF.sln" (default target) (1) ->
> "C:\projects\reef\lang\cs\Org.Apache.REEF.Network.Examples.Client\Org.Apache.REEF.Network.Examples.Client.csproj"
(default target) (24) ->
> "C:\projects\reef\lang\cs\Org.Apache.REEF.Bridge\Org.Apache.REEF.Bridge.vcxproj" (default
target) (25) ->
> (ClCompile target) -> 
> InteropUtil.cpp(138): error C2146: syntax error : missing ';' before identifier 'JNIEnv'
[C:\projects\reef\lang\cs\Org.Apache.REEF.Bridge\Org.Apache.REEF.Bridge.vcxproj]
> InteropUtil.cpp(138): error C4430: missing type specifier - int assumed. Note: C++ does
not support default-int [C:\projects\reef\lang\cs\Org.Apache.REEF.Bridge\Org.Apache.REEF.Bridge.vcxproj]
> {code}
> (e.g. see AppVeyor logs [here|https://ci.appveyor.com/project/ApacheSoftwareFoundation/reef/build/1974-master/job/i2chdmctv2w90dsi#L2985])
> It looks like the earlier versions of VS (managed) C++ do not support {{thread_local}}
keyword. We need to fix the code to make sure it compiles on all supported versions of Visual
Studio.
> The issue was likely introduced in [REEF-1895] (github pull request [#1385|https://github.com/apache/reef/pull/1385]).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message