reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim Doyoung (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1869) Refactoring Wake Transport and related codes
Date Tue, 22 Aug 2017 04:02:00 GMT

    [ https://issues.apache.org/jira/browse/REEF-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136231#comment-16136231
] 

Kim Doyoung commented on REEF-1869:
-----------------------------------

I apologize that I wrote in confusing words. The HTTP will be implemented with Netty. but
I found it is somewhat hard to implement it without changing former interface of Transport
and implementation of Netty code in Transport. Also It has some not well-formed codes. So
I created this issue to change the style and refactor the Transport part.

But I'm strongly agree with you that this issue have mixed issue. IMHO, It would be better
to create a new issue for Fixing style and to continue changing interface of Transport in
issue REEF-362 to Transport can accept HTTP. Thank you for your opinion!

> Refactoring Wake Transport and related codes
> --------------------------------------------
>
>                 Key: REEF-1869
>                 URL: https://issues.apache.org/jira/browse/REEF-1869
>             Project: REEF
>          Issue Type: Improvement
>          Components: Wake
>            Reporter: Kim Doyoung
>
> The Wake have some style issue and implementation issues.
> It is hard to implement another protocol than Netty by now. It can be changed by refactoring
the code to more suitable for using other protocols.
> The style refactoring also aims to refurbish the outdated code into more comprehensive
code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message