reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rogan Carr <rogan.c...@gmail.com>
Subject Re: Discussion: [REEF-1849] Fix CoreCLR incompatibilities in REEF Network
Date Wed, 02 Aug 2017 20:46:02 GMT
Hi Saikat,

Definitely a good option if we want to go the forked implementation route.
Can you point me to the PR?

Best,
Rogan

On Wed, Aug 2, 2017 at 1:40 PM, Saikat Kanjilal <sxk1969@gmail.com> wrote:

> Rogan,
> A while ago I had written an implementation of custom implementation of
> namedCache for .ney coreto solve compatibility issues, any interest in
> reusing that for this?
>
> I can try to dig up the code if there's interest, I believe it was
> actually code reviewed.
>
> Regards
>
> Sent from my iPhone
>
> > On Aug 2, 2017, at 4:05 PM, Rogan Carr <rogan.carr@gmail.com> wrote:
> >
> > Hi All,
> >
> > Org.Apache.REEF.Network has one main .NET Core incompatibility: It uses
> > System.Runtime.Caching for its memory cache.
> >
> > I drafted a solution in PR-1349 [1], and I'd like feedback before I
> > continue on with this.
> >
> > The problem with this solution is that it requires
> >  - Changes to the NameCacheConfiguration
> >    i.e. Changes to a public interface
> >  - Removal of (unused) internal functions in NameCache.
> >
> > One option to make transitioning less abrupt would be to leave NameCache
> in
> > place and introduce a separate, .NET Core Compatible implementation. We
> > could then use compile-time flags (i.e `DOTNET_BUILD) to make the .NET
> > compliant implementation the default in the Core build and deprecate the
> > non-core implementation.
> >
> > Thoughts?
> >
> > Best,
> > Rogan
> >
> > [1] https://github.com/apache/reef/pull/1349
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message