reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julia Wang (QIUHE)" <Qiuhe.W...@microsoft.com.INVALID>
Subject RE: build broken from master branch!
Date Wed, 19 Jul 2017 22:07:38 GMT
I would think it is better to switch to release build as release build covers more than debug
build. 

Julia

-----Original Message-----
From: Mariia Mykhailova [mailto:mamykhai@microsoft.com.INVALID] 
Sent: Wednesday, July 19, 2017 3:03 PM
To: dev@reef.apache.org
Subject: RE: build broken from master branch!

AppVeyor uses Debug configuration, we can switch it to Release if needed

-Mariia

-----Original Message-----
From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com.INVALID]
Sent: Wednesday, July 19, 2017 3:00 PM
To: dev@reef.apache.org
Subject: RE: build broken from master branch!

I updated the client side to v4.1. The error is gone. However, for release build, I still
have this error:

"C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.Bridge.CLR\Org.Apache.REEF.Bridge.CLR.csproj"
(default target) (36) -> (BuildPackage target) ->
  C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.targets(148,9): error : Could not find file
'C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.Bridge.CLR\Org.Apache.REEF.Bridge.CLR.
nuspec'. [C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.Bridge.CLR\Org.Apache.REEF.Bridge.CLR.csproj]
  C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.targets(148,9): error MSB3073: The command
""C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.exe" pack "C:\Reef\ReefApache\reef\lang\c s\\Org.Apache.REEF.Bridge.CLR\Org.Apache.REEF.Bridge.CLR.nuspec"
-BasePath C:\Reef\ReefApache\reef\lang\cs\\Org.Apache.REEF.Bridge -Properties "Configuration=Release;Platform=x64
;REEF_Version=0.16.0-SNAPSHOT;Version=0.16.0-SNAPSHOT-06" -NonInteractive -OutputDirectory
"C:\Reef\ReefApache\reef\lang\cs\\.nuget\packages" " exited with code 1. [C:\Reef\ReefA pache\reef\lang\cs\Org.Apache.REEF.Bridge.CLR\Org.Apache.REEF.Bridge.CLR.csproj]

If we are not going to have NuGet for Bridge.CLR, we should not create it in the project.


Does AppVeyor use debug build or release build? 

Julia

-----Original Message-----
From: Douglas Service [mailto:dsopsrc@gmail.com]
Sent: Wednesday, July 19, 2017 1:36 PM
To: dev@reef.apache.org
Subject: Re: build broken from master branch!

We should be using nuget version 4.1 for AppVeyor builds which is downloaded as part of the
build process. See https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Freef%2Fpull%2F1319&data=02%7C01%7CQiuhe.Wang%40microsoft.com%7Cb21109021244433c906b08d4cee5e2d9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636360934160574043&sdata=HaTX517IcwkA4qYfChHFWFOG7ky%2BjHJvI3Q7eLNLCtc%3D&reserved=0.

On Wed, Jul 19, 2017 at 1:31 PM, Douglas Service <dsopsrc@gmail.com> wrote:

> It appears that visual studio uses its own version of nuget when you 
> compile from visual studio. I discovered this recently working with 
> the Avro C# serialization code where the 2.7 version of nuget we were 
> downloading for command line builds did not handle entries marked as 
> developmentDependencies in the packages.config file properly; however, 
> building with Visual Studio did handle them correctly. Thus I had to 
> upgrade the version we use to 4.1 to get the same behavior as Visual 
> Studio in command line builds.
>
> On Wed, Jul 19, 2017 at 12:42 PM, Julia Wang (QIUHE) < 
> Qiuhe.Wang@microsoft.com.invalid> wrote:
>
>> Boris said they use their own fork. They don't have dependency on VS2013.
>>
>> -----Original Message-----
>> From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com.INVALID]
>> Sent: Wednesday, July 19, 2017 12:23 PM
>> To: dev@reef.apache.org
>> Subject: RE: build broken from master branch!
>>
>> Hi Boris,
>>
>> Do you still use VS2013 for REEF?
>>
>> Julia
>>
>> -----Original Message-----
>> From: Mariia Mykhailova [mailto:mamykhai@microsoft.com.INVALID]
>> Sent: Wednesday, July 19, 2017 11:26 AM
>> To: dev@reef.apache.org
>> Subject: RE: build broken from master branch!
>>
>> Which implies that if we want to keep support for VS2013 we have to 
>> stay on NuGet 2.8.6, or we don't have CI. It might be time to drop
>> VS2013 support, but I remember Boris had concerns about this.
>>
>> -Mariia
>>
>> -----Original Message-----
>> From: Mariia Mykhailova [mailto:mamykhai@microsoft.com.INVALID]
>> Sent: Wednesday, July 19, 2017 11:23 AM
>> To: dev@reef.apache.org
>> Subject: RE: build broken from master branch!
>>
>> It might this change that is breaking our VS2013 AppVeyor build in 
>> master (https://na01.safelinks.protection.outlook.com/?url=https%
>> 3A%2F%2Fci.appveyor.com%2Fproject%2FApacheSoftwareFoundation
>> %2Freef%2Fbuild%2F1691-master&data=02%7C01%7Cmamykhai%40micr
>> osoft.com%7Ce5610aeeed514319020408d4ced32b4c%7C72f988bf86f14
>> 1af91ab2d7cd011db47%7C1%7C0%7C636360853735748389&sdata=LRTkW
>> ZiyoFz%2FUHIVHQBcCxHB4smIK8WYVCo8zNmcDYA%3D&reserved=0,
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%
>> 2F%2Fci.appveyor.com%2Fproject%2FApacheSoftwareFoundation%2F
>> reef%2Fbuild%2F1698-master&data=02%7C01%7Cmamykhai%40microso
>> ft.com%7Ce5610aeeed514319020408d4ced32b4c%7C72f988bf86f141af
>> 91ab2d7cd011db47%7C1%7C0%7C636360853735748389&sdata=ZEw6VoBU
>> dNQbRa5M89Z9WoOcHHl0scGhqWpjf2BxtOU%3D&reserved=0) - from AppVeyor 
>> documentation 
>> (https://na01.safelinks.protection.outlook.com/?url=https%
>> 3A%2F%2Fwww.appveyor.com%2Fdocs%2Fbuild-environment%2F&
>> data=02%7C01%7Cmamykhai%40microsoft.com%7Ce5610aeeed51
>> 4319020408d4ced32b4c%7C72f988bf86f141af91ab2d7cd011db47%7C1%
>> 7C0%7C636360853735748389&sdata=EFvu9zmtDS3inHp8xtY8zUkp
>> J7uNjhE4Q6RKYD9dn48%3D&reserved=0), VS2013 build environment has only 
>> NuGet 2.8.6 installed
>>
>> I don't know though why this didn't show in build for pull request or 
>> why
>> VS2015 and VS2017 are broken (they are supposed to have NuGet 4.1.0
>> installed)
>>
>> -Mariia
>>
>> -----Original Message-----
>> From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com.INVALID]
>> Sent: Wednesday, July 19, 2017 11:21 AM
>> To: dev@reef.apache.org
>> Subject: RE: build broken from master branch!
>>
>> What is the NuGet version we shall use?
>>
>> -----Original Message-----
>> From: Rogan Carr [mailto:rogan.carr@gmail.com]
>> Sent: Wednesday, July 19, 2017 11:19 AM
>> To: dev@reef.apache.org
>> Subject: Re: build broken from master branch!
>>
>> Hi Julia,
>>
>> This is from my recent commit updating the System.Reactive libraries.
>>
>> Do we need to target a specific version of the Nuget client? If not, 
>> can you update your client and try again? If we do have a version 
>> requirement, let's add that to the project.
>>
>> Best,
>> Rogan
>>
>> On Wed, Jul 19, 2017 at 11:11 AM, Markus Weimer <markus@weimo.de> wrote:
>>
>> > I can't repro myself, as I am stuck on other build issues, but:
>> > Wouldn't an update of your NuGet client fix this?
>> >
>> > Markus
>> >
>> > On Wed, Jul 19, 2017 at 10:47 AM, Julia Wang (QIUHE) 
>> > <Qiuhe.Wang@microsoft.com.invalid> wrote:
>> > > After sync from master this morning, when I build on the command 
>> > > line, I
>> > got the following build error:
>> > >
>> > > "C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.sln" (default
>> > > target)
>> > (1) ->
>> > > "C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.Tang.
>> > Examples\Org.Apache.REEF.Tang.Examples.csproj" (default target) (5)
>> > ->
>> > > "C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.Wake\Org.Ap
>> ache.REEF.Wake.csproj"
>> > (default target) (6) ->
>> > > (RestorePackages target) ->
>> > >   C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.targets(135,9): 
>> > > error
>> :
>> > The 'System.Reactive.Core 3.1.1' package requires NuGet client 
>> > version '2.12' or above, but the current NuG
>> > > et version is '2.8.60717.93'. [C:\Reef\ReefApache\reef\lang\
>> > cs\Org.Apache.REEF.Wake\Org.Apache.REEF.Wake.csproj]
>> > >   C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.targets(135,9): 
>> > > error
>> :
>> > The 'System.Reactive.Interfaces 3.1.1' package requires NuGet 
>> > client version '2.12' or above, but the curre
>> > > nt NuGet version is '2.8.60717.93'. 
>> > > [C:\Reef\ReefApache\reef\lang\
>> > cs\Org.Apache.REEF.Wake\Org.Apache.REEF.Wake.csproj]
>> > >   C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.targets(135,9): 
>> > > error
>> > MSB3073: The command ""C:\Reef\ReefApache\reef\lang
>> \cs\.nuget\NuGet.exe"
>> > install "C:\Reef\ReefApache\reef\lan
>> > > g\cs\Org.Apache.REEF.Wake\packages.config" -source ""
>> > > -NonInteractive
>> > -RequireConsent -solutionDir "C:\Reef\ReefApache\reef\lang\cs\ ""
>> > exited with code 1. [C:\Reef\ReefApache\r
>> > > eef\lang\cs\Org.Apache.REEF.Wake\Org.Apache.REEF.Wake.csproj]
>> > >
>> > > It breaks 6 projects in the solution. This error happens in both 
>> > > debug
>> > and release build. After I did clean for all the binaries and 
>> > packages, the error still come out during the build.
>> > >
>> > > Julia
>> >
>>
>
>
Mime
View raw message