reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Markus Weimer <mar...@weimo.de>
Subject Re: build broken from master branch!
Date Wed, 19 Jul 2017 20:03:49 GMT
Once we have the release done, we won't support VS 2013 anymore as per
prior discussions. Hence, this particular problem should solved
itself. Meanwhile, we need to update the documentation in `build.md`
to reflect this requirement. -- Markus

On Wed, Jul 19, 2017 at 1:02 PM, Julia Wang (QIUHE)
<Qiuhe.Wang@microsoft.com.invalid> wrote:
> Hi Mariia,
>
> Do you know how to update NuGet.exe version in AppVeyor?
>
> Julia
>
> -----Original Message-----
> From: Rogan Carr [mailto:rogan.carr@gmail.com]
> Sent: Wednesday, July 19, 2017 1:00 PM
> To: dev@reef.apache.org
> Subject: Re: build broken from master branch!
>
> Hi Julia,
>
> Thanks for checking on the VS2013 dependency. Does this mean we can update NuGet to 2.12+,
or shall I roll back that commit?
>
> Best,
> Rogan
>
> On Wed, Jul 19, 2017 at 12:42 PM, Julia Wang (QIUHE) < Qiuhe.Wang@microsoft.com.invalid>
wrote:
>
>> Boris said they use their own fork. They don't have dependency on VS2013.
>>
>> -----Original Message-----
>> From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com.INVALID]
>> Sent: Wednesday, July 19, 2017 12:23 PM
>> To: dev@reef.apache.org
>> Subject: RE: build broken from master branch!
>>
>> Hi Boris,
>>
>> Do you still use VS2013 for REEF?
>>
>> Julia
>>
>> -----Original Message-----
>> From: Mariia Mykhailova [mailto:mamykhai@microsoft.com.INVALID]
>> Sent: Wednesday, July 19, 2017 11:26 AM
>> To: dev@reef.apache.org
>> Subject: RE: build broken from master branch!
>>
>> Which implies that if we want to keep support for VS2013 we have to
>> stay on NuGet 2.8.6, or we don't have CI. It might be time to drop
>> VS2013 support, but I remember Boris had concerns about this.
>>
>> -Mariia
>>
>> -----Original Message-----
>> From: Mariia Mykhailova [mailto:mamykhai@microsoft.com.INVALID]
>> Sent: Wednesday, July 19, 2017 11:23 AM
>> To: dev@reef.apache.org
>> Subject: RE: build broken from master branch!
>>
>> It might this change that is breaking our VS2013 AppVeyor build in
>> master ( https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fci.appveyor.com%2Fproject%2FApacheSoftwareFoundation%
>> 2Freef%2Fbuild%2F1691-master&data=02%7C01%7Cmamykhai%40microsoft.com%
>> 7Ce5610aeeed514319020408d4ced32b4c%7C72f988bf86f141af91ab2d7cd011
>> db47%7C1%7C0%7C636360853735748389&sdata=LRTkWZiyoFz%
>> 2FUHIVHQBcCxHB4smIK8WYVCo8zNmcDYA%3D&reserved=0, https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fna01.safelinks&data=02%7C01%7CQiuhe.Wang%40microsoft.com%7Cf54b39efadeb4726a3dc08d4cee0bfbb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636360912076222062&sdata=C41flYggenvUFwbtomTu7uxYrlFWaiAygKgElXL3c7g%3D&reserved=0.
>> protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%
>> 2FApacheSoftwareFoundation%2Freef%2Fbuild%2F1698-master&
>> data=02%7C01%7Cmamykhai%40microsoft.com%7Ce5610aeeed514319020408d4ced3
>> 2b4c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%
>> 7C636360853735748389&sdata=ZEw6VoBUdNQbRa5M89Z9WoOcHHl0sc
>> GhqWpjf2BxtOU%3D&reserved=0) - from AppVeyor documentation (
>> https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fwww.appveyor.com%2Fdocs%2Fbuild-environment%2F&data=02%7
>> C01% 7Cmamykhai%40microsoft.com%7Ce5610aeeed514319020408d4ced32b4c%
>> 7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636360853735748389&sdata=
>> EFvu9zmtDS3inHp8xtY8zUkpJ7uNjhE4Q6RKYD9dn48%3D&reserved=0), VS2013
>> build environment has only NuGet 2.8.6 installed
>>
>> I don't know though why this didn't show in build for pull request or
>> why
>> VS2015 and VS2017 are broken (they are supposed to have NuGet 4.1.0
>> installed)
>>
>> -Mariia
>>
>> -----Original Message-----
>> From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com.INVALID]
>> Sent: Wednesday, July 19, 2017 11:21 AM
>> To: dev@reef.apache.org
>> Subject: RE: build broken from master branch!
>>
>> What is the NuGet version we shall use?
>>
>> -----Original Message-----
>> From: Rogan Carr [mailto:rogan.carr@gmail.com]
>> Sent: Wednesday, July 19, 2017 11:19 AM
>> To: dev@reef.apache.org
>> Subject: Re: build broken from master branch!
>>
>> Hi Julia,
>>
>> This is from my recent commit updating the System.Reactive libraries.
>>
>> Do we need to target a specific version of the Nuget client? If not,
>> can you update your client and try again? If we do have a version
>> requirement, let's add that to the project.
>>
>> Best,
>> Rogan
>>
>> On Wed, Jul 19, 2017 at 11:11 AM, Markus Weimer <markus@weimo.de> wrote:
>>
>> > I can't repro myself, as I am stuck on other build issues, but:
>> > Wouldn't an update of your NuGet client fix this?
>> >
>> > Markus
>> >
>> > On Wed, Jul 19, 2017 at 10:47 AM, Julia Wang (QIUHE)
>> > <Qiuhe.Wang@microsoft.com.invalid> wrote:
>> > > After sync from master this morning, when I build on the command
>> > > line, I
>> > got the following build error:
>> > >
>> > > "C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.sln" (default
>> > > target)
>> > (1) ->
>> > > "C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.Tang.
>> > Examples\Org.Apache.REEF.Tang.Examples.csproj" (default target) (5)
>> > ->
>> > > "C:\Reef\ReefApache\reef\lang\cs\Org.Apache.REEF.Wake\Org.
>> Apache.REEF.Wake.csproj"
>> > (default target) (6) ->
>> > > (RestorePackages target) ->
>> > >   C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.targets(135,9): error :
>> > The 'System.Reactive.Core 3.1.1' package requires NuGet client
>> > version '2.12' or above, but the current NuG
>> > > et version is '2.8.60717.93'. [C:\Reef\ReefApache\reef\lang\
>> > cs\Org.Apache.REEF.Wake\Org.Apache.REEF.Wake.csproj]
>> > >   C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.targets(135,9): error :
>> > The 'System.Reactive.Interfaces 3.1.1' package requires NuGet client
>> > version '2.12' or above, but the curre
>> > > nt NuGet version is '2.8.60717.93'. [C:\Reef\ReefApache\reef\lang\
>> > cs\Org.Apache.REEF.Wake\Org.Apache.REEF.Wake.csproj]
>> > >   C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.targets(135,9):
>> > > error
>> > MSB3073: The command ""C:\Reef\ReefApache\reef\lang\cs\.nuget\NuGet.exe"
>> > install "C:\Reef\ReefApache\reef\lan
>> > > g\cs\Org.Apache.REEF.Wake\packages.config" -source ""
>> > > -NonInteractive
>> > -RequireConsent -solutionDir "C:\Reef\ReefApache\reef\lang\cs\ ""
>> > exited with code 1. [C:\Reef\ReefApache\r
>> > > eef\lang\cs\Org.Apache.REEF.Wake\Org.Apache.REEF.Wake.csproj]
>> > >
>> > > It breaks 6 projects in the solution. This error happens in both
>> > > debug
>> > and release build. After I did clean for all the binaries and
>> > packages, the error still come out during the build.
>> > >
>> > > Julia
>> >
>>

Mime
View raw message