reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Douglas Service <dsop...@gmail.com>
Subject Re: reef git commit: [REEF-1832] Duplicated Newtonsoft.Json entry in Org.Apache.REEF.Bridge.CLR causing errors in VS build
Date Tue, 18 Jul 2017 01:36:13 GMT
Hello Julia,

The duplicated entry is on purpose. However, it looks like it is not
necessary with the new version of nuget.exe that I recently updated us to
in another pull request. The latest version of nuget.exe seems to recognize
that Microsoft.Avro.Core depends on the latest version of Netwonsoft and
downloads both the 8.0.3 and 10.0.3 versions as they both appear when
building from either the command line or visual studio after a git clean
-xdf.

Doug

On Mon, Jul 17, 2017 at 5:44 PM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com.invalid> wrote:

> Hi Doug,
>
> The error is only on Visual Studio. Is it on purpose or we shall remove
> duplicated entry?
>
> Julia
>
> -----Original Message-----
> From: Douglas Service [mailto:dsopsrc@gmail.com]
> Sent: Monday, July 17, 2017 4:48 PM
> To: dev@reef.apache.org
> Subject: Re: reef git commit: [REEF-1832] Duplicated Newtonsoft.Json entry
> in Org.Apache.REEF.Bridge.CLR causing errors in VS build
>
> Are you building from the command line or visual studio. One of the
> versions of Newtonsoft.Json is marked as a build dependency which means it
> is supposed to be downloaded so as to be available to build tools but not
> linked in. This works when building from the command line.
>
>
> On Fri, Jul 14, 2017 at 3:28 PM, <motus@apache.org> wrote:
>
> > Repository: reef
> > Updated Branches:
> >   refs/heads/master 7a417393c -> a64383667
> >
> >
> > [REEF-1832]  Duplicated Newtonsoft.Json entry in
> > Org.Apache.REEF.Bridge.CLR causing errors in VS build
> >
> > JIRA:
> > [REEF-1832](https://na01.safelinks.protection.outlook.com/?url=https%3
> > A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FREEF-1832&data=02%7C01%7CQi
> > uhe.Wang%40microsoft.com%7C75fd7e36c13c4b6708dc08d4cd6e57f4%7C72f988bf
> > 86f141af91ab2d7cd011db47%7C1%7C0%7C636359321182884398&sdata=2q1zMPK5OK
> > NWqKSzIZaTRQ21QSVzW3Q7pVR9uKQYDIA%3D&reserved=0)
> > This closes #
> >
> >
> > Project:
> > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wi
> > p-us.apache.org%2Frepos%2Fasf%2Freef%2Frepo&data=02%7C01%7CQiuhe.Wang%
> > 40microsoft.com%7C75fd7e36c13c4b6708dc08d4cd6e57f4%7C72f988bf86f141af9
> > 1ab2d7cd011db47%7C1%7C0%7C636359321182884398&sdata=8zHJG0a7p68vauMMylr
> > mf5GT9QpmjAjC91eaByddn3o%3D&reserved=0
> > Commit:
> > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wi
> > p-us.apache.org%2Frepos%2Fasf%2Freef%2Fcommit%2Fa6438366&data=02%7C01%
> > 7CQiuhe.Wang%40microsoft.com%7C75fd7e36c13c4b6708dc08d4cd6e57f4%7C72f9
> > 88bf86f141af91ab2d7cd011db47%7C1%7C0%7C636359321182884398&sdata=oGcsbR
> > 0F%2BzIfGC2SU9gPOCYmfj3EeZfznSLalKHndwQ%3D&reserved=0
> > Tree:
> > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wi
> > p-us.apache.org%2Frepos%2Fasf%2Freef%2Ftree%2Fa6438366&data=02%7C01%7C
> > Qiuhe.Wang%40microsoft.com%7C75fd7e36c13c4b6708dc08d4cd6e57f4%7C72f988
> > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636359321182884398&sdata=podoFcR1
> > RD5CgCRh0BoP2K%2FXVNxEJzJQcNH5BPMeAS8%3D&reserved=0
> > Diff:
> > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wi
> > p-us.apache.org%2Frepos%2Fasf%2Freef%2Fdiff%2Fa6438366&data=02%7C01%7C
> > Qiuhe.Wang%40microsoft.com%7C75fd7e36c13c4b6708dc08d4cd6e57f4%7C72f988
> > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636359321182884398&sdata=NdWfqDuR
> > YLPs5seeX8Uo2%2BErAdYvWkoWLg46aXafxq8%3D&reserved=0
> >
> > Branch: refs/heads/master
> > Commit: a64383667ed5fd1878c0ff5289222031713c13c6
> > Parents: 7a41739
> > Author: Julia Wang <juliaw@apache.org>
> > Authored: Thu Jul 13 19:47:27 2017 -0700
> > Committer: Julia Wang <juliaw@apache.org>
> > Committed: Thu Jul 13 19:47:27 2017 -0700
> >
> > ----------------------------------------------------------------------
> >  lang/cs/Org.Apache.REEF.Bridge.CLR/packages.config | 1 -
> >  1 file changed, 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wi
> > p-us.apache.org%2Frepos%2Fasf%2Freef%2Fblob%2Fa6438366%2F&data=02%7C01
> > %7CQiuhe.Wang%40microsoft.com%7C75fd7e36c13c4b6708dc08d4cd6e57f4%7C72f
> > 988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636359321182884398&sdata=5A8Jc
> > 7PLBCZu7cW5L3iN2sRSQzqccR6nz%2FvW0rjxwiQ%3D&reserved=0
> > lang/cs/Org.Apache.REEF.Bridge.CLR/packages.config
> > ----------------------------------------------------------------------
> > diff --git a/lang/cs/Org.Apache.REEF.Bridge.CLR/packages.config
> > b/lang/cs/Org.Apache.REEF.Bridge.CLR/packages.config
> > index 26c8722..a0941f8 100644
> > --- a/lang/cs/Org.Apache.REEF.Bridge.CLR/packages.config
> > +++ b/lang/cs/Org.Apache.REEF.Bridge.CLR/packages.config
> > @@ -20,7 +20,6 @@ under the License.
> >  <packages>
> >    <package id="Microsoft.Avro.Core" version="0.1.0"
> > targetFramework="net451" developmentDependency="true" />
> >    <package id="Microsoft.Avro.Tools" version="0.1.0"
> > targetFramework="net451" developmentDependency="true" />
> > -  <package id="Newtonsoft.Json" version="10.0.3"
> targetFramework="net451"
> > developmentDependency="true" />
> >    <package id="Microsoft.Hadoop.Avro" version="1.5.6"
> > targetFramework="net45" />
> >    <package id="Newtonsoft.Json" version="8.0.3" targetFramework="net45"
> />
> >    <package id="StyleCop.MSBuild" version="4.7.49.1"
> > targetFramework="net45" developmentDependency="true" />
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message