reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rogan Carr <rogan.c...@gmail.com>
Subject Re: Protobuf.NET could be .NET Core compatible
Date Tue, 18 Jul 2017 18:13:50 GMT
Talked to @singlis <https://github.com/singlis> in person and worked
through the issue. Looks like it was an issue with my Visual Studio 2017
setup. There were no changes in the commit that could have caused this
error.

Testing now.

On Tue, Jul 18, 2017 at 10:58 AM, Scott Inglis <msinglft@gmail.com> wrote:

> Hey Rogan -- sorry I missed this.
>
> I did do a clean and rebuild:
> git clean -xdf
> mvn clean install
>
> You are seeing these when building from the command line?
>
>
>
> On Fri, Jul 14, 2017 at 9:41 AM, Rogan Carr <rogan.carr@gmail.com> wrote:
>
> > Hi Scott,
> >
> > I can't build this branch. I've attached my build errors.
> >
> > Did you do a clean before you build?
> >
> > Also, I get some errors that I've never seen before -- could these be the
> > issue?
> >
> > Best,
> > Rogan
> >
> > ---- weird errors ----
> > Error                   Invalid Resx file. Could not find file
> > 'C:\Users\rogan\Projects\otherReefs\reef\lang\cs\bin\
> > x64\Debug\Org.Apache.REEF.Brid\
> > ge\Org.Apache.REEF.Bridge.exe'. Line 79, position
> > 5.
> > Org.Apach\
> > e.REEF.Client
> >
> > \
> >                     C:\Users\rogan\Projects\otherReefs\reef\lang\cs\bin\
> > x64\Debug\Org.Apache.REEF.Client\Resources.resx 79
> > Error                   MSB8036 The Windows SDK version 10.0.15063.0 was
> > not found. Install the required version of Windows SDK or change the SDK
> \
> > version in the project property pages or by right-clicking the solution
> > and selecting "Retarget solution".
> > Org.Apach\
> > e.REEF.Bridge
> >
> > \
> >                     C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\Enterprise\Common7\IDE\VC\VCTargets\Platforms\x64\
> > PlatformToolsets\v141\To\
> > olset.targets 36
> >
> > ---- /weird errors ----
> >
> > On Thu, Jul 13, 2017 at 6:09 PM, Scott Inglis <msinglft@gmail.com>
> wrote:
> >
> >> I don't have access to one. If you don't mind, that would be great, but
> at
> >> some point I could use the experience to walk through running on a Yarn
> >> cluster.
> >>
> >> Here is my branch:
> >> https://github.com/apache/reef/compare/master...singlis:REEF-1830
> >>
> >> Thank you!
> >>
> >>
> >> On Thu, Jul 13, 2017 at 4:48 PM, Rogan Carr <rogan.carr@gmail.com>
> wrote:
> >>
> >> > Also, thanks for doing this! It was at the top of my list :)
> >> >
> >> > On Thu, Jul 13, 2017 at 4:48 PM, Rogan Carr <rogan.carr@gmail.com>
> >> wrote:
> >> >
> >> > > Hi Scott,
> >> > >
> >> > > Can you please try HelloREEF and the IMRU.Examples on a Yarn
> cluster?
> >> > >
> >> > > If you don't have access, I have one I could run your build on.
> >> > >
> >> > > Best,
> >> > > Rogan
> >> > >
> >> > > On Thu, Jul 13, 2017 at 4:39 PM, Scott Inglis <msinglft@gmail.com>
> >> > wrote:
> >> > >
> >> > >> Hello --
> >> > >>
> >> > >> I'm volunteering for this.
> >> > >>
> >> > >> It does look like 2.1.0 will work as it has binaries for 451 as
> well
> >> as
> >> > >> netstandard 1.3 and 1.5. I have updated the REEF projects with
this
> >> > >> library
> >> > >> and have run the tests locally -- all pass. I'm running a mvn
clean
> >> just
> >> > >> to
> >> > >> be sure.
> >> > >>
> >> > >> I will also try the 2nd suggestion of trying this version of the
> >> library
> >> > >> in
> >> > >> the dot net projects to confirm it works there as well.
> >> > >>
> >> > >>
> >> > >> I will create a JIRA for updating to protobuf 2.1.0.
> >> > >>
> >> > >>
> >> > >> Is there any additional testing that needs to be done?
> >> > >>
> >> > >> Thanks,
> >> > >>
> >> > >> Scott
> >> > >>
> >> > >>
> >> > >> On Sat, Apr 22, 2017 at 6:18 PM, Douglas Service <
> dsopsrc@gmail.com>
> >> > >> wrote:
> >> > >>
> >> > >> > This is great news.
> >> > >> >
> >> > >> > On Fri, Apr 21, 2017 at 3:32 PM, Markus Weimer <markus@weimo.de>
> >> > wrote:
> >> > >> >
> >> > >> > > Hi,
> >> > >> > >
> >> > >> > > Rogan and I just discovered that there has been a new
release
> >> 2.1.0
> >> > of
> >> > >> > > Protobuf-net which claims compatibility with NetStandard
1.3
> [0].
> >> > This
> >> > >> > > could be *fantastic* news for our port to Linux, as
we could
> >> evade
> >> > the
> >> > >> > > whole "replace protobuf with avro" work for a little
longer.
> >> > >> > >
> >> > >> > > To know whether this actually *is* fantastic, we need
to do two
> >> > >> things:
> >> > >> > >
> >> > >> > > (1) Update the current main build of REEF to use 2.1.0
and test
> >> it
> >> > in
> >> > >> > > YARN and locally. If it passes, we know that the update
does
> not
> >> > break
> >> > >> > > us, and we can also update to version 2.1.0 for good.
> >> > >> > >
> >> > >> > > (2) Test that the 2.1.0 version is actually compatible
with
> >> > >> > > netstandard in one of our projects.
> >> > >> > >
> >> > >> > >
> >> > >> > > Both of these can proceed in parallel. Any volunteers
for
> either
> >> > one?
> >> > >> > >
> >> > >> > > Thanks,
> >> > >> > >
> >> > >> > > Markus
> >> > >> > >
> >> > >> > >
> >> > >> > > [0]: https://www.nuget.org/packages/protobuf-net/
> >> > >> > >
> >> > >> >
> >> > >>
> >> > >
> >> > >
> >> >
> >>
> >
> >
> > On Thu, Jul 13, 2017 at 6:09 PM, Scott Inglis <msinglft@gmail.com>
> wrote:
> >
> >> I don't have access to one. If you don't mind, that would be great, but
> at
> >> some point I could use the experience to walk through running on a Yarn
> >> cluster.
> >>
> >> Here is my branch:
> >> https://github.com/apache/reef/compare/master...singlis:REEF-1830
> >>
> >> Thank you!
> >>
> >>
> >> On Thu, Jul 13, 2017 at 4:48 PM, Rogan Carr <rogan.carr@gmail.com>
> wrote:
> >>
> >> > Also, thanks for doing this! It was at the top of my list :)
> >> >
> >> > On Thu, Jul 13, 2017 at 4:48 PM, Rogan Carr <rogan.carr@gmail.com>
> >> wrote:
> >> >
> >> > > Hi Scott,
> >> > >
> >> > > Can you please try HelloREEF and the IMRU.Examples on a Yarn
> cluster?
> >> > >
> >> > > If you don't have access, I have one I could run your build on.
> >> > >
> >> > > Best,
> >> > > Rogan
> >> > >
> >> > > On Thu, Jul 13, 2017 at 4:39 PM, Scott Inglis <msinglft@gmail.com>
> >> > wrote:
> >> > >
> >> > >> Hello --
> >> > >>
> >> > >> I'm volunteering for this.
> >> > >>
> >> > >> It does look like 2.1.0 will work as it has binaries for 451 as
> well
> >> as
> >> > >> netstandard 1.3 and 1.5. I have updated the REEF projects with
this
> >> > >> library
> >> > >> and have run the tests locally -- all pass. I'm running a mvn
clean
> >> just
> >> > >> to
> >> > >> be sure.
> >> > >>
> >> > >> I will also try the 2nd suggestion of trying this version of the
> >> library
> >> > >> in
> >> > >> the dot net projects to confirm it works there as well.
> >> > >>
> >> > >>
> >> > >> I will create a JIRA for updating to protobuf 2.1.0.
> >> > >>
> >> > >>
> >> > >> Is there any additional testing that needs to be done?
> >> > >>
> >> > >> Thanks,
> >> > >>
> >> > >> Scott
> >> > >>
> >> > >>
> >> > >> On Sat, Apr 22, 2017 at 6:18 PM, Douglas Service <
> dsopsrc@gmail.com>
> >> > >> wrote:
> >> > >>
> >> > >> > This is great news.
> >> > >> >
> >> > >> > On Fri, Apr 21, 2017 at 3:32 PM, Markus Weimer <markus@weimo.de>
> >> > wrote:
> >> > >> >
> >> > >> > > Hi,
> >> > >> > >
> >> > >> > > Rogan and I just discovered that there has been a new
release
> >> 2.1.0
> >> > of
> >> > >> > > Protobuf-net which claims compatibility with NetStandard
1.3
> [0].
> >> > This
> >> > >> > > could be *fantastic* news for our port to Linux, as
we could
> >> evade
> >> > the
> >> > >> > > whole "replace protobuf with avro" work for a little
longer.
> >> > >> > >
> >> > >> > > To know whether this actually *is* fantastic, we need
to do two
> >> > >> things:
> >> > >> > >
> >> > >> > > (1) Update the current main build of REEF to use 2.1.0
and test
> >> it
> >> > in
> >> > >> > > YARN and locally. If it passes, we know that the update
does
> not
> >> > break
> >> > >> > > us, and we can also update to version 2.1.0 for good.
> >> > >> > >
> >> > >> > > (2) Test that the 2.1.0 version is actually compatible
with
> >> > >> > > netstandard in one of our projects.
> >> > >> > >
> >> > >> > >
> >> > >> > > Both of these can proceed in parallel. Any volunteers
for
> either
> >> > one?
> >> > >> > >
> >> > >> > > Thanks,
> >> > >> > >
> >> > >> > > Markus
> >> > >> > >
> >> > >> > >
> >> > >> > > [0]: https://www.nuget.org/packages/protobuf-net/
> >> > >> > >
> >> > >> >
> >> > >>
> >> > >
> >> > >
> >> >
> >>
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message