reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rogan Carr <rogan.c...@gmail.com>
Subject Re: REEF-1818: Upgrade System.Reactive.* to 3x for CoreCLR Compatibility
Date Sat, 01 Jul 2017 18:38:21 GMT
Hi Mariia,

>>This branch also has some whitespace-only changes and a lot of changes
related to Newtonsoft.Json package (which also shouldn't be necessary
because we have lang/cs/App.config which deals with Newtonsoft.Json and
gets binplaced to all projects during the build).
>>I don't think we should be doing these changes under the umbrella of
upgrading System.Reactive packages.

Thanks for catching these. I'm not sure how they happened -- I'll make sure
they get cleaned up before I send in a PR!

Best,
Rogan

On Fri, Jun 30, 2017 at 1:10 PM, Mariia Mykhailova <
mamykhai@microsoft.com.invalid> wrote:

> This branch also has some whitespace-only changes and a lot of changes
> related to Newtonsoft.Json package (which also shouldn't be necessary
> because we have lang/cs/App.config which deals with Newtonsoft.Json and
> gets binplaced to all projects during the build).
> I don't think we should be doing these changes under the umbrella of
> upgrading System.Reactive packages.
>
> -Mariia
>
> -----Original Message-----
> From: Rogan Carr [mailto:rogan.carr@gmail.com]
> Sent: Friday, June 30, 2017 12:45 PM
> To: dev@reef.apache.org
> Subject: Re: REEF-1818: Upgrade System.Reactive.* to 3x for CoreCLR
> Compatibility
>
> Hi Julia!
>
> I haven't started a PR yet because I need to clean up my commit history a
> bit (WIP comments, mostly).
>
> My branch is here:
> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Frogancarr%2Freef%2Ftree%
> 2Ffeature%2Freef-1818_Upgrade_System.Reactive_to_3.x&data=
> 02%7C01%7Cmamykhai%40microsoft.com%7Ca92ba55496ad46cfecb008d4bff0900f%
> 7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636344487332343959&sdata=
> r4mXE1rc7TQk020jlbRFRuGHCWELq83nxA87X%2FY2vS0%3D&reserved=0
>
> Thanks for your help!
>
> Best,
> Rogan
>
> On Fri, Jun 30, 2017 at 12:39 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com.invalid> wrote:
>
> > Hi Rogan,
> >
> > Where is your PL? I can pull it to try it in my dev box.
> >
> > Thanks,
> > Julia
> >
> > -----Original Message-----
> > From: Rogan Carr [mailto:rogan.carr@gmail.com]
> > Sent: Friday, June 30, 2017 12:27 PM
> > To: dev@reef.apache.org
> > Subject: Re: REEF-1818: Upgrade System.Reactive.* to 3x for CoreCLR
> > Compatibility
> >
> > Quick note: I will run these tests on Wednesday when I'm back from a
> trip.
> > I have to refocus on something else today.
> >
> > On Fri, Jun 30, 2017 at 11:54 AM, Mariia Mykhailova <
> > mamykhai@microsoft.com.invalid> wrote:
> >
> > > Then we need to figure out the cause of this failure before we can
> > > proceed with the testing.
> > >
> > > Can anybody else reproduce this failure? Unfortunately I don't have
> > > a dev setup of REEF currently, so can't check myself.
> > >
> > > -Mariia
> > >
> > > -----Original Message-----
> > > From: Rogan Carr [mailto:rogan.carr@gmail.com]
> > > Sent: Friday, June 30, 2017 10:33 AM
> > > To: dev@reef.apache.org
> > > Subject: Re: REEF-1818: Upgrade System.Reactive.* to 3x for CoreCLR
> > > Compatibility
> > >
> > > Hi All,
> > >
> > > First, let me address the dependencies. System.Reactive 3.x (and the
> > > forthcoming 4.x) support .NET 4.5+ [1][2].
> > >
> > > As for the TestTaskLifeCycle, this is the issue:
> > >
> > > """
> > > TaskRuntimeTests.cs line 109
> > > Message: Assert.Equal() Failure
> > > Expected: RUNNING
> > > Actual:   DONE
> > > """
> > >
> > > I get this consistently in main.
> > >
> > > Best,
> > > Rogan
> > >
> > > [1] 3.x supports 4.5+
> > > From https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fwww.nuget.org%2Fpackages%2FSystem.Reactive&
> > > data=02%7C01%7Cmamykhai%40microsoft.com%7C4517dd8cc4074ad2af8a08d4bf
> > > de 0783%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%
> > > 7C636344407704953178&sdata=FQVlFx%2B1V5Aap0RsUHKRlz0Ctsbl1HIbtTG
> > > Xuy8rNs8%3D&reserved=0
> > > """
> > > Dependencies
> > >
> > >    - .NETCore 4.5.1
> > >       - System.Reactive.PlatformServices
> > >       <https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fwww.nuget.org%2Fpackages%2FSystem.Reactive.
> > > PlatformServices%2F&data=02%7C01%7Cmamykhai%40microsoft.com%
> > > 7C4517dd8cc4074ad2af8a08d4bfde0783%7C72f988bf86f141af91ab2d7cd011
> > > db47%7C1%7C0%7C636344407704953178&sdata=Pen2J0vItVZ3D8lCfjDkDthD1d1F
> > > ZS
> > > l5rQBI%2BmbT8Uo%3D&reserved=0> (>=
> > >       3.1.1)
> > >       - System.Reactive.Windows.Threading
> > >       <https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fwww.nuget.org%2Fpackages%2FSystem.Reactive.
> > > Windows.Threading%2F&data=02%7C01%7Cmamykhai%40microsoft.com%
> > > 7C4517dd8cc4074ad2af8a08d4bfde0783%7C72f988bf86f141af91ab2d7cd011
> > > db47%7C1%7C0%7C636344407704953178&sdata=9YTA24d8hQLr6kDa%
> > > 2FNiTDxYDerCoNYZy6E%2FDT%2B34SrU%3D&reserved=0> (>=
> > >       3.1.1)
> > >       - System.Reactive.WindowsRuntime
> > >       <https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fwww.nuget.org%2Fpackages%2FSystem.Reactive.
> > > WindowsRuntime%2F&data=02%7C01%7Cmamykhai%40microsoft.com%
> > > 7C4517dd8cc4074ad2af8a08d4bfde0783%7C72f988bf86f141af91ab2d7cd011
> > > db47%7C1%7C0%7C636344407704953178&sdata=d3oOUQu43d6bK%2BJuv6fYJO%
> > > 2FQf96TzvV3hPtRT5to2tQ%3D&reserved=0> (>=
> > >       3.1.1)
> > >    - .NETFramework 4.5
> > >       - System.Reactive.PlatformServices
> > >       <https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fwww.nuget.org%2Fpackages%2FSystem.Reactive.
> > > PlatformServices%2F&data=02%7C01%7Cmamykhai%40microsoft.com%
> > > 7C4517dd8cc4074ad2af8a08d4bfde0783%7C72f988bf86f141af91ab2d7cd011
> > > db47%7C1%7C0%7C636344407704953178&sdata=Pen2J0vItVZ3D8lCfjDkDthD1d1F
> > > ZS
> > > l5rQBI%2BmbT8Uo%3D&reserved=0> (>=
> > >       3.1.1)
> > >       - System.Reactive.Windows.Threading
> > >       <https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fwww.nuget.org%2Fpackages%2FSystem.Reactive.
> > > Windows.Threading%2F&data=02%7C01%7Cmamykhai%40microsoft.com%
> > > 7C4517dd8cc4074ad2af8a08d4bfde0783%7C72f988bf86f141af91ab2d7cd011
> > > db47%7C1%7C0%7C636344407704953178&sdata=9YTA24d8hQLr6kDa%
> > > 2FNiTDxYDerCoNYZy6E%2FDT%2B34SrU%3D&reserved=0> (>=
> > >       3.1.1)
> > >
> > > """
> > >
> > > [2] https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fgithub.com%2FReactive-Extensions%2FRx.
> > > NET%23v40-changes&data=02%7C01%7Cmamykhai%40microsoft.com%
> > > 7C4517dd8cc4074ad2af8a08d4bfde0783%7C72f988bf86f141af91ab2d7cd011
> > > db47%7C1%7C0%7C636344407704953178&sdata=9MwhjOtscj3SQuUsJGitI%
> > > 2BUK2Fj1uHEX2Bzo8hLStPw%3D&reserved=0
> > > """
> > >
> > > Rx 4.0 supports the following platforms
> > >
> > >    - .NET Framework 4.5+
> > >    - .NET Standard 1.3+ (including .NET Core, Xamarin and others)
> > >    - UWP
> > >
> > > """
> > >
> > > On Thu, Jun 29, 2017 at 8:00 PM, Douglas Service <dsopsrc@gmail.com>
> > > wrote:
> > >
> > > > Do we have a list of the transiently failing tests somewhere for
> > > > every to refer to as needed?
> > > >
> > > > Doug
> > > >
> > > > On Thu, Jun 29, 2017 at 2:25 PM, Mariia Mykhailova <
> > > > mamykhai@microsoft.com.invalid> wrote:
> > > >
> > > > > Rogan,
> > > > > Could you please provide details on the failure of
> > > > > TestTaskLifeCycle on master branch? This is not one of the known
> > > > > transiently failing tests (at least it's not reported in JIRA),
> > > > > and the latest AppVeyor build on
> > > > master (
> > > > > https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fci.
> > > > > appveyor.com%2Fproject%2FApacheSoftwareFoundation%2Freef%2F&data
> > > > > =0
> > > > > 2%
> > > > > 7C01%7Cmamykhai%40microsoft.com%7C4517dd8cc4074ad2af8a08d4bfde07
> > > > > 83
> > > > > %7
> > > > > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636344407704953178&s
> > > > > da
> > > > > ta
> > > > > =JYsq%2Fgjp4afV0SRFflghol46sMf3OriAAzz0i%2BE4aKs%3D&reserved=0
> > > > > build/1630-master) has this test passing.
> > > > >
> > > > > -Mariia
> > > > >
> > > > > -----Original Message-----
> > > > > From: Rogan Carr [mailto:rogan.carr@gmail.com]
> > > > > Sent: Thursday, June 29, 2017 7:41 AM
> > > > > To: dev@reef.apache.org
> > > > > Subject: REEF-1818: Upgrade System.Reactive.* to 3x for CoreCLR
> > > > > Compatibility
> > > > >
> > > > > Hi All,
> > > > >
> > > > > I've opened REEF-1818 [1] to upgrade the System.Reactive
> > > > > libraries to 3.x branch because they are CoreCLR compatible
> > > > > versions of the Reactive libraries.
> > > > >
> > > > > I created a branch and tested out upgrading to the 3.x branch.
> > > > > REEF
> > > > builds
> > > > > successfully, and all tests pass (except for Yarn tests and
> > > > > `TestTaskLifeCycle()` -- but these fail in the master branch too).
> > > > >
> > > > > Now, question for the community: Is there any reason to not
> > > > > upgrade these to the 3.x branch? Also, are there any other tests
> > > > > that I should run
> > > > other
> > > > > than the ones we have coded up?
> > > > >
> > > > > Thanks for your help!
> > > > >
> > > > > Best,
> > > > > Rogan
> > > > >
> > > > > [1] https://na01.safelinks.protection.outlook.com/?url=
> > > > > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FREEF-
> > > > > 1818&data=02%7C01%7Cmamykhai%40microsoft.com%
> > > > > 7Caf01d6e5dc2e46ca781308d4befcdc75%7C72f988bf86f141af91ab2d7cd01
> > > > > 1
> > > > > db47%7C1%7C0%7C636343440617227640&sdata=ONIN5PdoZWPrmQbYm5jmmfJR
> > > > > Zj
> > > > > q7
> > > > > bZ
> > > > > JKKJiAnsvlWX0%3D&reserved=0
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message