reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mariia Mykhailova <mamyk...@microsoft.com.INVALID>
Subject RE: REEF-1818: Upgrade System.Reactive.* to 3x for CoreCLR Compatibility
Date Thu, 29 Jun 2017 21:25:21 GMT
Rogan,
Could you please provide details on the failure of TestTaskLifeCycle on master branch? This
is not one of the known transiently failing tests (at least it's not reported in JIRA), and
the latest AppVeyor build on master (https://ci.appveyor.com/project/ApacheSoftwareFoundation/reef/build/1630-master)
has this test passing.

-Mariia

-----Original Message-----
From: Rogan Carr [mailto:rogan.carr@gmail.com] 
Sent: Thursday, June 29, 2017 7:41 AM
To: dev@reef.apache.org
Subject: REEF-1818: Upgrade System.Reactive.* to 3x for CoreCLR Compatibility

Hi All,

I've opened REEF-1818 [1] to upgrade the System.Reactive libraries to 3.x branch because they
are CoreCLR compatible versions of the Reactive libraries.

I created a branch and tested out upgrading to the 3.x branch. REEF builds successfully, and
all tests pass (except for Yarn tests and `TestTaskLifeCycle()` -- but these fail in the master
branch too).

Now, question for the community: Is there any reason to not upgrade these to the 3.x branch?
Also, are there any other tests that I should run other than the ones we have coded up?

Thanks for your help!

Best,
Rogan

[1] https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FREEF-1818&data=02%7C01%7Cmamykhai%40microsoft.com%7Caf01d6e5dc2e46ca781308d4befcdc75%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636343440617227640&sdata=ONIN5PdoZWPrmQbYm5jmmfJRZjq7bZJKKJiAnsvlWX0%3D&reserved=0
Mime
View raw message