reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1804) TestFailMapperEvaluatorsWithFailedResultHandlerOnDispose test fails in AppVeyor
Date Wed, 24 May 2017 18:43:04 GMT

    [ https://issues.apache.org/jira/browse/REEF-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023428#comment-16023428
] 

Markus Weimer commented on REEF-1804:
-------------------------------------

Good call of [REEF-1778] as the potential trigger for this. When I look at the test code,
I wonder whether the test itself isn't the problem. As I understand it, the job submission
in these tests is done via {{IMRUBrodcastReduceTestBase.TestBroadCastAndReduce}}. That in
turn calls {{TestRun()}} in the same class. That method, in turn calls {{IREEFClient.SubmitAndGetJobStatus()}}
to submit the job. 

However, that last method *does not wait* for the job to complete. Instead, we poll for the
existence of the Driver's log file in {{ReefFunctionalTest.ReadLogFile()}}. 

I wonder: Is there any guarantee that this works? Will we potentially read the file prematurely?

> TestFailMapperEvaluatorsWithFailedResultHandlerOnDispose test fails in AppVeyor
> -------------------------------------------------------------------------------
>
>                 Key: REEF-1804
>                 URL: https://issues.apache.org/jira/browse/REEF-1804
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Mariia Mykhailova
>
> {{TestFailMapperEvaluatorsWithFailedResultHandlerOnDispose.TestFailedMapperOnLocalRuntime}}
fails in AppVeyor very frequently (around 9 runs out of 10). 
> {noformat}
> Assert.Equal() Failure
> Expected: 9
> Actual:   10
> {noformat}
> I suspect the culprit is REEF-1778, since this change does modify behavior of task disposal,
and the test started failing around that time.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message