reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mariia Mykhailova <mamyk...@microsoft.com.INVALID>
Subject RE: java/C# build question
Date Fri, 05 May 2017 17:34:27 GMT
I think -q was introduced when we set up CI, so that the console output from Java build doesn't
overwhelm .NET console output (and CI can actually show it - my browser choked on 10k+ lines
of console output)

Nothing exciting should actually happen during Java build when done from .NET side - if there
is a Java build failure, it should manifest in Java build done separately.

-Mariia

-----Original Message-----
From: Douglas Service [mailto:dsopsrc@gmail.com] 
Sent: Thursday, May 4, 2017 5:16 PM
To: dev@reef.apache.org
Subject: Re: java/C# build question

Also would anyone mind if we removed the -q from the maven commands in the Bridge.Jar csproj
file so the user is aware or what really happened during the maven build. It is also very
useful to see that output when working on both sides.

Doug

On Fri, May 5, 2017 at 12:12 AM, Douglas Service <dsopsrc@gmail.com> wrote:

> I assume you are referring to the this section of the 
> Org.Apache.REEF.Bridge.Jar.csproj file?  Or is there also copying done 
> elsewhere.
>
>  <Target Name="Build"
>           DependsOnTargets="CheckMavenInstall;CheckJavaInstall;
> CheckProtocInstall"
>           Outputs="$(OutputPath)">
>     <PropertyGroup>
>       <!--The shaded jar of the bridge (driver side) -->
>       <Bridge_JAR_Name>reef-bridge-java-$(REEF_Version)-shaded.
> jar</Bridge_JAR_Name>
>       <Bridge_JAR>$(REEF_Source_Folder)\lang\java\reef-bridge-
> java\target\$(Bridge_JAR_Name)</Bridge_JAR>
>       <!--The shaded jar of the bridge (client side) -->
>       <Client_JAR_Name>reef-bridge-client-$(REEF_Version)-shaded.
> jar</Client_JAR_Name>
>       <Client_JAR>$(REEF_Source_Folder)\lang\java\reef-bridge-
> client\target\$(Client_JAR_Name)</Client_JAR>
>     </PropertyGroup>
>     <Exec Command='call "$(M2_HOME)\bin\mvn.cmd" --projects 
> lang/java/reef-bridge-java,lang/java/reef-bridge-client --also-make 
> -TC1 -DskipTests -P!code-quality install' Condition="!Exists('$(Bridge_JAR)')"
> WorkingDirectory="$(REEF_Source_Folder)" />
>     <Copy DestinationFolder="$(OutputPath)" SourceFiles="$(Bridge_JAR)" />
>     <Copy DestinationFolder="$(OutputPath)" SourceFiles="$(Client_JAR)" />
>   </Target>
>
>
> On Thu, May 4, 2017 at 8:47 PM, Markus Weimer <markus@weimo.de> wrote:
>
>> We copy the JARs to the output folder via MSBuild. If they already 
>> exist, that rule in MSBuild will not trigger. We probably should 
>> expand the trigger to consider the case where the JAR changed in its 
>> original location.
>>
>> Markus
>>
>> On Thu, May 4, 2017 at 1:18 PM, Julia Wang (QIUHE) 
>> <Qiuhe.Wang@microsoft.com.invalid> wrote:
>> > Only remove those two:
>> >
>> > reef-bridge-client-0.16.0-SNAPSHOT-shaded.jar
>> > reef-bridge-java-0.16.0-SNAPSHOT-shaded.jar
>> >
>> > -----Original Message-----
>> > From: Douglas Service [mailto:dsopsrc@gmail.com]
>> > Sent: Thursday, May 4, 2017 1:16 PM
>> > To: dev@reef.apache.org
>> > Subject: Re: java/C# build question
>> >
>> > Running Get-ChildItem *.jar -Recurse in the bin directory returns 
>> > the
>> following list. So we should recursively remove any jar files in the 
>> lang\cs\bin directory?
>> >
>> >
>> >     Directory: E:\reef\lang\cs\bin\Temp
>> >
>> >
>> > Mode                LastWriteTime         Length Name
>> > ----                -------------         ------ ----
>> > d-----         5/4/2017   7:39 PM
>> Org.Apache.REEF.Bridge.JAR
>> >
>> >
>> >     Directory: E:\reef\lang\cs\bin\x64\Debug
>> >
>> >
>> > Mode                LastWriteTime         Length Name
>> > ----                -------------         ------ ----
>> > d-----         5/4/2017   7:41 PM
>> Org.Apache.REEF.Bridge.JAR
>> >
>> >
>> >     Directory: 
>> > E:\reef\lang\cs\bin\x64\Debug\Org.Apache.REEF.Bridge.JAR
>> >
>> >
>> > Mode                LastWriteTime         Length Name
>> > ----                -------------         ------ ----
>> > -a----         5/4/2017   7:39 PM       12598475
>> > reef-bridge-client-0.16.0-SNAPSHOT-shaded.jar
>> > -a----         5/4/2017   7:39 PM       10824897
>> > reef-bridge-java-0.16.0-SNAPSHOT-shaded.jar
>> >
>> >
>> >     Directory: E:\reef\lang\cs\bin\x64\Debug\Org.Apache.REEF.Client
>> >
>> >
>> > Mode                LastWriteTime         Length Name
>> > ----                -------------         ------ ----
>> > -a----         5/4/2017   7:39 PM       12598475
>> > reef-bridge-client-0.16.0-SNAPSHOT-shaded.jar
>> > -a----         5/4/2017   7:39 PM       10824897
>> > reef-bridge-java-0.16.0-SNAPSHOT-shaded.jar
>> >
>> >
>> >     Directory:
>> > E:\reef\lang\cs\bin\x64\Debug\Org.Apache.REEF.Examples.HelloREEF
>> >
>> >
>> > Mode                LastWriteTime         Length Name
>> > ----                -------------         ------ ----
>> > -a----         5/4/2017   7:42 PM       12598475
>> > reef-bridge-client-0.16.0-SNAPSHOT-shaded.jar
>> > -a----         5/4/2017   7:42 PM       10824897
>> > reef-bridge-java-0.16.0-SNAPSHOT-shaded.jar
>> >
>> > On Thu, May 4, 2017 at 8:03 PM, Sergiy Matusevych <
>> sergiy.matusevych@gmail.com> wrote:
>> >
>> >> Hmm, if that's indeed the case, we can add pre-build script in 
>> >> msbuild to remove the cached jars.. I will try to reproduce the 
>> >> error once I have
>> >> vs2017 installed
>> >>
>> >> -- Sergiy.
>> >>
>> >> On Thu, May 4, 2017 at 12:46 PM, Douglas Service 
>> >> <dsopsrc@gmail.com>
>> >> wrote:
>> >>
>> >> > I am currently doing work on both the Java and C# side for REEF-1763.
>> >> > However, after I build the java side before rebuilding and 
>> >> > testing the C# side, the Java changes do not show up on the C# 
>> >> > side unless I do a git clean -xdf before building both sides 
>> >> > which seems a little
>> heavy handed.
>> >> I
>> >> > looked in the Org.Apache.REEF.Bridge.JAR file and it seems the
>> >> dependencies
>> >> > there should take care of the issue, but they do not. It is as 
>> >> > if Visual Studio is caching the jar file Does anyone else see 
>> >> > this issue? I am running with only VS2017 installed.
>> >> >
>> >> > Doug
>> >> >
>> >>
>>
>
>
Mime
View raw message