reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boris Shulman <shulm...@gmail.com>
Subject Re: Moving to .net framework 4.5.1 for reef .net builds
Date Thu, 09 Mar 2017 01:26:51 GMT
I am ok moving to 4.5.1 or 4.5.2

Sent from my iPhone

> On Mar 8, 2017, at 4:24 PM, Saikat Kanjilal <sxk1969@gmail.com> wrote:
> 
> So I've implemented a relatively simple in Memory Cache replacement
> (backup plan per above discussion) with a timer associated with each
> entries (simple Dicioinary), I've made fixes to the code to ensure that all
> current Network Unit tests run successfully which they now do, some
> questions come to mind:
> 1) What other unit tests do I need to run to see the larger impact of this
> change, some documentation around this would be great
> 2) I was wondering what folks think about taking this approach as opposed
> to the 451 approach, some insights around this would be good to discuss on
> the list
> 3) In general it'd be good to understand what unit tests to run for any
> change, case in point I see that unit tests around the scatter yarn are
> failing and from what I can see these have no relationship to my changes ,
> I will run the unit tests on master to confirm that they all work as well.
> 
> 
> Thoughts?
> 
>> On Wed, Mar 8, 2017 at 12:45 PM, Saikat Kanjilal <sxk1969@gmail.com> wrote:
>> 
>> I'll respond in bulk :
>> 1) I have not yet run through all the unit tests in the Network Library
>> project so I don't know the answer to this
>> 2) I assume the major features are spread across multiple APIs, I havent
>> yet researched these, I do know that Microsoft.Extensions.Caching.Memory.MemoryCache
>> is only supported on this version of the .Net Framework
>> 2) I will wait to hear from Boris on usage issues before doing anything
>> 
>> FYI.. as a backup alternative means to move ahead I am also implementing a
>> basic in memory cache to replace MemoryCache and fixing the unit tests to
>> work with that.
>> 
>> On Wed, Mar 8, 2017 at 12:31 PM, Mariia Mykhailova <
>> mamykhai@microsoft.com.invalid> wrote:
>> 
>>> Boris Shulman definitely had concerns about moving to 4.6. You'll need
>>> his +1 to move to 4.5.1, I don't know whether this move will cause issues
>>> for his usage.
>>> 
>>> -Mariia
>>> 
>>> -----Original Message-----
>>> From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com.INVALID]
>>> Sent: Wednesday, March 8, 2017 11:52 AM
>>> To: dev@reef.apache.org
>>> Subject: RE: Moving to .net framework 4.5.1 for reef .net builds
>>> 
>>> Hi Saikat,
>>> 
>>> Thanks for driving it!
>>> 
>>> What are the major features that .net 4.5.1 will bring?
>>> Any backward compatibility issues you are aware of? Did you try it, build
>>> and run tests with .Net 4.5.1?
>>> 
>>> Thanks,
>>> Julia
>>> 
>>> -----Original Message-----
>>> From: Saikat Kanjilal [mailto:sxk1969@gmail.com]
>>> Sent: Wednesday, March 8, 2017 11:19 AM
>>> To: dev@reef.apache.org
>>> Subject: Re: Moving to .net framework 4.5.1 for reef .net builds
>>> 
>>> Apologies for repeated emails but we need to make a decision soon as to
>>> whether or not to move forward with using the Microsoft.Extensions.Caching.Memory
>>> API which is supported in .Net Framework 4.5.1 as opposed to 4.5, I will
>>> wait till the end of the day to hear from reef users and will assume that
>>> if I don't hear back it's ok to move to 4.5.1, please do let me know if
>>> moving to this version is an issue
>>> for you.   It would be also great to get a +1 from a large subset of the
>>> committers who care about this before I move forward to not make any
>>> decisions without data :)
>>> 
>>> Thanks in advance.
>>> 
>>> On Tue, Mar 7, 2017 at 3:22 PM, Saikat Kanjilal <sxk1969@gmail.com>
>>> wrote:
>>> 
>>>> Hello Reef Users,
>>>> I was wondering if it'll be ok  to move to 4.5.1 as the minimum .NET
>>>> version for existing users of REEF?  Will this break people's current
>>>> workflow with reef, please respond so that we can get a data driven
>>>> gauge for this decision.
>>>> 
>>>> Thanks in advance.
>>>> 
>>> 
>> 
>> 

Mime
View raw message