Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 27C69200C00 for ; Wed, 4 Jan 2017 02:48:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2656C160B49; Wed, 4 Jan 2017 01:48:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 967DB160B43 for ; Wed, 4 Jan 2017 02:48:04 +0100 (CET) Received: (qmail 47244 invoked by uid 500); 4 Jan 2017 01:47:58 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 47012 invoked by uid 99); 4 Jan 2017 01:47:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2017 01:47:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9BBBE2C2A67 for ; Wed, 4 Jan 2017 01:47:58 +0000 (UTC) Date: Wed, 4 Jan 2017 01:47:58 +0000 (UTC) From: "Julia (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (REEF-1690) Replace Skip attribute with Trait for .NET tests running on Yarn MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 04 Jan 2017 01:48:05 -0000 [ https://issues.apache.org/jira/browse/REEF-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julia resolved REEF-1690. ------------------------- Resolution: Fixed Fix Version/s: 0.16 resolved via https://github.com/apache/reef/pull/1209 > Replace Skip attribute with Trait for .NET tests running on Yarn > ---------------------------------------------------------------- > > Key: REEF-1690 > URL: https://issues.apache.org/jira/browse/REEF-1690 > Project: REEF > Issue Type: Sub-task > Components: REEF.NET > Reporter: Mariia Mykhailova > Assignee: Mariia Mykhailova > Fix For: 0.16 > > > xUnit doesn't execute tests annotated with {{[Fact(Skip)]}} even if instructed to run this specific test explicitly. To run some .NET tests on Yarn, we need them to be enabled, so we can't use {{Skip}} anymore. > We will use trait of environment instead and run local tests with {{-notrait "Environment=Yarn"}} option to exclude these tests from command line local runs. These tests can also be excluded from Visual Studio runs by using {{-Trait:Environment}} in Test Explorer (having to do this is the only behavior change introduced by this JIRA). If these tests are executed on local box, they'll fail, as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)