reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1526) Warn if an Evaluator is in several states simultaneously.
Date Fri, 27 Jan 2017 22:51:24 GMT

    [ https://issues.apache.org/jira/browse/REEF-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843608#comment-15843608
] 

Mariia Mykhailova commented on REEF-1526:
-----------------------------------------

[~motus] You've refactored this code recently as part of REEF-1557, what do you think? The
possibility of evaluator being in several states simultaneously looks like there's no proper
lock in methods which access {{EvaluatorState}}; should we just make the methods synchronized?

> Warn if an Evaluator is in several states simultaneously.
> ---------------------------------------------------------
>
>                 Key: REEF-1526
>                 URL: https://issues.apache.org/jira/browse/REEF-1526
>             Project: REEF
>          Issue Type: Improvement
>            Reporter: Sergey Dudoladov
>
> Methods like {code}isDoneOrFailedOrKilled(){code} in EvaluatorManager.java check the
evaluator state using logical "or", which potentially allows an Evaluator to be in several
states simultaneously.
> We should log such situations at the warning level because they indicate abnormal behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message