Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2E241200BE8 for ; Fri, 9 Dec 2016 07:16:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2CBD2160B30; Fri, 9 Dec 2016 06:16:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A43D6160B1F for ; Fri, 9 Dec 2016 07:15:59 +0100 (CET) Received: (qmail 10836 invoked by uid 500); 9 Dec 2016 06:15:58 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 10809 invoked by uid 99); 9 Dec 2016 06:15:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2016 06:15:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9FF092C0086 for ; Fri, 9 Dec 2016 06:15:58 +0000 (UTC) Date: Fri, 9 Dec 2016 06:15:58 +0000 (UTC) From: "Julia (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (REEF-1683) Use default MaxRetryNumberInRecovery properly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 09 Dec 2016 06:16:00 -0000 [ https://issues.apache.org/jira/browse/REEF-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julia updated REEF-1683: ------------------------ Labels: FT (was: ) > Use default MaxRetryNumberInRecovery properly > --------------------------------------------- > > Key: REEF-1683 > URL: https://issues.apache.org/jira/browse/REEF-1683 > Project: REEF > Issue Type: Bug > Reporter: Julia > Assignee: Julia > Priority: Minor > Labels: FT > Fix For: 0.16 > > > Currently in IMRUJobDefinitionBuilder, the default _maxRetryNumberInRecovery is set to 0. In REEFIMRUClient and some test code, we bind the value in IMRUJobDefinition to the named parameter MaxRetryNumberInRecovery. If the user doesn't set this value in IMRUJobDefinitionBuilder when creating IMRUJobDefinition, the default value 0 is bound to the NamedParameter, which override the named parameter MaxRetryNumberInRecovery's own default value. > In IMRUDriver, to avoid this override, we set another default value and replace the value passed in if it 0. That caused some confusion. > A correct way should be, if the user doesn't set, REEFIMRUClient should not bind 0 to the named parameter, that would allow the named parameter's own default value to be used. And when we look for the default value, the one set in the named parameter should be the unique place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)