Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D11E4200BE8 for ; Fri, 9 Dec 2016 07:17:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CF916160B27; Fri, 9 Dec 2016 06:17:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4CA25160B1F for ; Fri, 9 Dec 2016 07:17:59 +0100 (CET) Received: (qmail 12333 invoked by uid 500); 9 Dec 2016 06:17:58 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 12307 invoked by uid 99); 9 Dec 2016 06:17:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2016 06:17:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5D40D2C0086 for ; Fri, 9 Dec 2016 06:17:58 +0000 (UTC) Date: Fri, 9 Dec 2016 06:17:58 +0000 (UTC) From: "Julia (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (REEF-1677) IMRU: Evaluators failed during WaitingForEvaluator phase don't count towards MaximumNumberOfEvaluatorFailures limit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 09 Dec 2016 06:18:00 -0000 [ https://issues.apache.org/jira/browse/REEF-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julia updated REEF-1677: ------------------------ Labels: FT (was: ) > IMRU: Evaluators failed during WaitingForEvaluator phase don't count towards MaximumNumberOfEvaluatorFailures limit > ------------------------------------------------------------------------------------------------------------------- > > Key: REEF-1677 > URL: https://issues.apache.org/jira/browse/REEF-1677 > Project: REEF > Issue Type: Bug > Components: IMRU > Reporter: Mariia Mykhailova > Assignee: Mariia Mykhailova > Labels: FT > Fix For: 0.16 > > > In {{IMRUDriver}}, we keep track of the list of failed evaluator ids, and use its length when we need to find out how many evaluators failed. However, if evaluator failed in {{WaitingForEvaluator}} state we immediately remove it from this list and request another evaluator, effectively forgetting about the failure. Thus, even with lots of evaluators failing at this stage we'll never hit {{MaximumNumberOfEvaluatorFailures}} limit, and will keep requesting new evaluators indefinitely. > I think we should just remove this list (with the additional benefit of reduced memory consumption) and replace it with a single counter which is never decremented. We're only using the values in the list for sanity checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)