reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julia (JIRA)" <>
Subject [jira] [Assigned] (REEF-1683) Use default MaxRetryNumberInRecovery properly
Date Fri, 02 Dec 2016 22:23:58 GMT


Julia reassigned REEF-1683:

    Assignee: Julia

> Use default MaxRetryNumberInRecovery properly
> ---------------------------------------------
>                 Key: REEF-1683
>                 URL:
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Julia
>            Assignee: Julia
>            Priority: Minor
> Currently in IMRUJobDefinitionBuilder, the default _maxRetryNumberInRecovery is set to
0. In REEFIMRUClient and some test code, we bind the value in  IMRUJobDefinition to the named
parameter MaxRetryNumberInRecovery. If the user doesn't set this value in IMRUJobDefinitionBuilder
when creating IMRUJobDefinition, the default value 0 is bound to the NamedParameter, which
override the named parameter MaxRetryNumberInRecovery's own default value. 
> In IMRUDriver, to avoid this override, we set another default value and replace the value
passed in if it 0. That caused some confusion. 
> A correct way should be, if the user doesn't  set, REEFIMRUClient should not bind 0 to
the named parameter, that would allow the named parameter's own default value to be used.
 And when we look for the default value, the one set in the named parameter should be the
unique place. 

This message was sent by Atlassian JIRA

View raw message