reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <>
Subject [jira] [Commented] (REEF-1621) Fix TestTransportServerEvent failures in AppVeyor
Date Thu, 29 Dec 2016 23:12:58 GMT


Mariia Mykhailova commented on REEF-1621:

I spent some time investigating this test failures, and there's something suspicious going
on. I've modified {{TransportTest}} so that each test uses different test messages (instead
of all tests sharing the same message, like now), and it turns out that {{TestTransportServerEvent}}
sometimes gets a message or several from {{TestRaceCondition}} test. {{TestRaceCondition}},
in turn, doesn't consume all of its messages; it sends 150 non-empty messages, but consumes
only about 113-114 of them, and 36-37 of received messages are null.

I see two problems here:
1) tests are not sufficiently isolated, so one test can get messages from another.
2) empty messages received by {{TestRaceCondition}} instead of non-empty messages it sends.

Here is a log of an AppVeyor run which shows this:

Any ideas what's going on?

> Fix TestTransportServerEvent failures in AppVeyor
> -------------------------------------------------
>                 Key: REEF-1621
>                 URL:
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET
>            Reporter: Mariia Mykhailova
> Error message:
> {noformat}
> Assert.Equal() Failure
>           ↓ (pos 0)
> Expected: Hello
> Actual:   , 
>           ↑ (pos 0)
>    at Org.Apache.REEF.Wake.Tests.TransportTest.TestTransportServerEvent() in C:\projects\reef\lang\cs\Org.Apache.REEF.Wake.Tests\TransportTest.cs:line
> {noformat}
> Latest failure

This message was sent by Atlassian JIRA

View raw message