Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F070F200BD2 for ; Sat, 19 Nov 2016 03:15:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EEEBA160B19; Sat, 19 Nov 2016 02:15:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4E243160B04 for ; Sat, 19 Nov 2016 03:15:59 +0100 (CET) Received: (qmail 56636 invoked by uid 500); 19 Nov 2016 02:15:58 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 56616 invoked by uid 99); 19 Nov 2016 02:15:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Nov 2016 02:15:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6B9FF2C2B10 for ; Sat, 19 Nov 2016 02:15:58 +0000 (UTC) Date: Sat, 19 Nov 2016 02:15:58 +0000 (UTC) From: "Shravan Matthur Narayanamurthy (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (REEF-1674) Random Failures in Broadcast and Reduce Fault Tolerance tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 19 Nov 2016 02:16:00 -0000 [ https://issues.apache.org/jira/browse/REEF-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678396#comment-15678396 ] Shravan Matthur Narayanamurthy commented on REEF-1674: ------------------------------------------------------ Thanks for pointing this out. I took a look at this. Two things that stand out: First it is implemented as an event handler and it throws an exception. I am inside IMRU and don't have control over binding event handlers. Also I want to be able to just exit instead of throwing an exception. The redundancy in code is so small that I am inclined to just use what I have now instead of getting PoisonedEventHandler to work. WDYT? Let me submit a PR and you can tell me if there is a simple way to use PoisonedEventHandler. > Random Failures in Broadcast and Reduce Fault Tolerance tests > ------------------------------------------------------------- > > Key: REEF-1674 > URL: https://issues.apache.org/jira/browse/REEF-1674 > Project: REEF > Issue Type: Improvement > Components: REEF.NET IO > Affects Versions: 0.16 > Reporter: Shravan Matthur Narayanamurthy > Assignee: Shravan Matthur Narayanamurthy > Priority: Minor > Fix For: 0.16 > > > The current fault tolerance tests inject simulated failure in a controlled manner and hence are not the right failure model to test our fault tolerance work. It would be good to have failures injected randomly than only at specific points as is done in the current code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)