reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dhruv Mahajan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (REEF-1652) Change properties of UpdateResult in IMRU to public from internal
Date Mon, 24 Oct 2016 21:01:58 GMT

    [ https://issues.apache.org/jira/browse/REEF-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603206#comment-15603206
] 

Dhruv Mahajan edited comment on REEF-1652 at 10/24/16 9:01 PM:
---------------------------------------------------------------

BTW if I do that it's ok even if user does not use his own implementation since we can have
current {{UpdateResult}} as default implementation provided by REEF and fields have to be
made public any case since it will be implementing {{IUpdateResult}}.

But then what is the point of creating the interface since I do not think of scenario where
user will not use {{UpdateResult}}?


was (Author: dkm2110):
BTW if I do that it's ok even if user does not use his own implementation since we can have
current {{UpdateResult}} as default implementation provided by REEF and fields have to be
made public any case since it will be implementing {{IUpdateResult}}.

> Change properties of UpdateResult in IMRU to public from internal
> -----------------------------------------------------------------
>
>                 Key: REEF-1652
>                 URL: https://issues.apache.org/jira/browse/REEF-1652
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET
>         Environment: C#
>            Reporter: Dhruv Mahajan
>            Assignee: Dhruv Mahajan
>
> Currently all properties like {{MapInput}}, {{Result}} etc. in {{UpdateResult}} class
in IMRU are internal. This makes it very difficult for user to check functionality of  implementation
of their {{IUpdateFunction}}. Also with introduction of {{ITaskState}}, for testing purpose,
user might want to do a simulation in which it would be required to access {{UpdateResult}}
to feed it to mappers as in {{InProcessIMRU}}. The aim of the JIRA is to make these fields
public.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message