reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1652) Change properties of UpdateResult in IMRU to public from internal
Date Mon, 24 Oct 2016 19:55:58 GMT

    [ https://issues.apache.org/jira/browse/REEF-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603019#comment-15603019
] 

Markus Weimer commented on REEF-1652:
-------------------------------------

Why not replace {{UpdateResult}} with an {{interface IUpdateResult}}? That way, applications
can use their own implementation for tests.

> Change properties of UpdateResult in IMRU to public from internal
> -----------------------------------------------------------------
>
>                 Key: REEF-1652
>                 URL: https://issues.apache.org/jira/browse/REEF-1652
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET
>         Environment: C#
>            Reporter: Dhruv Mahajan
>            Assignee: Dhruv Mahajan
>
> Currently all properties like {{MapInput}}, {{Result}} etc. in {{UpdateResult}} class
in IMRU are internal. This makes it very difficult for user to check functionality of  implementation
of their {{IUpdateFunction}}. Also with introduction of {{ITaskState}}, for testing purpose,
user might want to do a simulation in which it would be required to access {{UpdateResult}}
to feed it to mappers as in {{InProcessIMRU}}. The aim of the JIRA is to make these fields
public.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message