reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (REEF-1650) Log warning about unclean evaluator shutdown only if evaluator is not closing yet
Date Mon, 24 Oct 2016 19:57:58 GMT

     [ https://issues.apache.org/jira/browse/REEF-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Markus Weimer resolved REEF-1650.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.16

Resolved via [#1165|https://github.com/apache/reef/pull/1165]

> Log warning about unclean evaluator shutdown only if evaluator is not closing yet
> ---------------------------------------------------------------------------------
>
>                 Key: REEF-1650
>                 URL: https://issues.apache.org/jira/browse/REEF-1650
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF-Common
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>            Priority: Minor
>             Fix For: 0.16
>
>
> Current code in {{Evaluators.java}} is
> {noformat}
>     for (final EvaluatorManager evaluatorManager : evaluatorsCopy) {
>       LOG.log(Level.WARNING, "Unclean shutdown of evaluator {0}", evaluatorManager.getId());
>       if (!evaluatorManager.isClosedOrClosing()) {
>         evaluatorManager.close();
>       }
>     }
> {noformat}
> The warning about unclean shutdown is posted even for evaluators which are already closed
or closing. We should move the log inside {{if}} statement, so that it is written only if
action is taken to close the evaluator forcefully.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message