reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey (JIRA)" <j...@apache.org>
Subject [jira] [Created] (REEF-1646) Allow optional configuration in ConfigurationBuilder
Date Wed, 19 Oct 2016 23:26:00 GMT
Andrey created REEF-1646:
----------------------------

             Summary: Allow optional configuration in ConfigurationBuilder
                 Key: REEF-1646
                 URL: https://issues.apache.org/jira/browse/REEF-1646
             Project: REEF
          Issue Type: Improvement
          Components: REEF
            Reporter: Andrey
            Priority: Minor


Currently ConfigurationBuilder does not seem to have any support optional configuration.
TangImpl.NewConfigurationBuilder(params IConfiguration[]) eventually calls ConfiguraitonBuilder
constructor which expects all configs to be non-null (throws Null Reference Exception otherwise)
In IMRU scenario code generating configs (JobDefinitionBuilder) and code assembling config
(ReefClient) is separated and the client code is forced to double check if configuration in
job definition was provided (if that configuration is optional) .
It would be nice to provide allow optional configurations either implicitly (by ignoring null
configs) or explicitly by adding specific API (AddOptionalConfiguration) which would ignore
nulls.
if we want to keep things as is force client to do the checks, we should probably fix the
constructor to throw ArgumentException instead of NullReference exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message