Mailing-List: contact dev-help@reef.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@reef.apache.org
Date: Fri, 16 Sep 2016 22:35:22 +0000 (UTC)
From: "Mariia Mykhailova (JIRA)" <jira@apache.org>
To: dev@reef.apache.org
Message-ID: <JIRA.13003407.1473292295000.593693.1474065322028@Atlassian.JIRA>
In-Reply-To: <JIRA.13003407.1473292295000@Atlassian.JIRA>
References: <JIRA.13003407.1473292295000@Atlassian.JIRA> <JIRA.13003407.1473292295768@arcas>
Subject: [jira] [Resolved] (REEF-1557) Refactor logic related to Evaluator
 state
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 16 Sep 2016 22:35:23 -0000


     [ https://issues.apache.org/jira/browse/REEF-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mariia Mykhailova resolved REEF-1557.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.16

Resolved via [PR 1118|https://github.com/apache/reef/pull/1118]

> Refactor logic related to Evaluator state
> -----------------------------------------
>
>                 Key: REEF-1557
>                 URL: https://issues.apache.org/jira/browse/REEF-1557
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF Driver
>            Reporter: Sergiy Matusevych
>            Assignee: Sergiy Matusevych
>            Priority: Minor
>              Labels: javadoc, refactoring
>             Fix For: 0.16
>
>
> We need to refactor the logic related to {{EvaluatorState}} and {{State}} enums. It is currently spread across several classes, and is not always consistent. Method names are clumsy, e.g. {{.isDoneOrFailedOrKilled()}}; {{EvaluatorStatusManager}} class has all its methods synchronized, although having an atomic enum reference would be enough. We also need to add more javadocs and clean up the code for readability.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)