reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (REEF-1557) Refactor logic related to Evaluator state
Date Fri, 16 Sep 2016 22:35:22 GMT

     [ https://issues.apache.org/jira/browse/REEF-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mariia Mykhailova resolved REEF-1557.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.16

Resolved via [PR 1118|https://github.com/apache/reef/pull/1118]

> Refactor logic related to Evaluator state
> -----------------------------------------
>
>                 Key: REEF-1557
>                 URL: https://issues.apache.org/jira/browse/REEF-1557
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF Driver
>            Reporter: Sergiy Matusevych
>            Assignee: Sergiy Matusevych
>            Priority: Minor
>              Labels: javadoc, refactoring
>             Fix For: 0.16
>
>
> We need to refactor the logic related to {{EvaluatorState}} and {{State}} enums. It is
currently spread across several classes, and is not always consistent. Method names are clumsy,
e.g. {{.isDoneOrFailedOrKilled()}}; {{EvaluatorStatusManager}} class has all its methods synchronized,
although having an atomic enum reference would be enough. We also need to add more javadocs
and clean up the code for readability.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message