reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mario Inchiosa <minchi...@gmail.com>
Subject Re: .NET Core Timmer issues
Date Thu, 22 Sep 2016 19:23:11 GMT
Since RxTimerStage is not used on either the Java or C#
side, `[Obsolete]`'ing it and subsequently deleting sounds good.
Since TimerStage is used a lot on the Java side, it might make sense to
keep it on the C# side, and Doug has already made it .NET Core-compliant.

On Tue, Sep 20, 2016 at 5:57 PM, Douglas Service <dsopsrc@gmail.com> wrote:

> The TimerStage class is used in the following tests on the java side.
>
>    - PubSubThreadPoolStageTest.java
>    - TimerStageTest.java
>    - LargeMsgTest.java
>    - RemoteManagerTest.java
>    - RemoteTest.java
>    - SmallMessagesTest.java
>    - TransportRaceTest.java
>    - TransportTest.java
>
> though it is not used on the C# side. However, The test code on the C# side
> appears to be incomplete compared to the java side so I am reticent to
> delete a class that we may need to provide complete test coverage on the C#
> side.
>
> The RxTimeStage class class on the other hand is not used on either the
> java or C# side so I agree we should [Osolete] the RxTimerClass and
> subsequently delete it both in Java and C#. Java
>
> The difference between TimerStage and RxTimerStage classes is that
> TimerStage calls EventHandler<PeriodicEvent> instance whereas calls an
> IStaticObservable for time out events.
>
> Doug
>
> On Thu, Sep 8, 2016 at 3:12 PM, Markus Weimer <markus@weimo.de> wrote:
>
> > On Thu, Sep 1, 2016 at 7:33 PM, Douglas Service <dsopsrc@gmail.com>
> wrote:
> > > Does anyone know what the original design requirements were for the the
> > > TimerStage and RXTimerStage classes? A search on timer stage does not
> > > reveal any usage of the classes in REEF.
> >
> > Maybe we should `[Obsolete]` them and delete them subsequently?
> >
> > Markus
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message