Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7C259200B63 for ; Mon, 15 Aug 2016 23:14:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7AC69160AB9; Mon, 15 Aug 2016 21:14:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C2748160AB8 for ; Mon, 15 Aug 2016 23:14:21 +0200 (CEST) Received: (qmail 59237 invoked by uid 500); 15 Aug 2016 21:14:20 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 59172 invoked by uid 99); 15 Aug 2016 21:14:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 21:14:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 93A072C02AA for ; Mon, 15 Aug 2016 21:14:20 +0000 (UTC) Date: Mon, 15 Aug 2016 21:14:20 +0000 (UTC) From: "Sergiy Matusevych (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (REEF-1532) Pass Time object instead of numeric timestamp in Timer methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 15 Aug 2016 21:14:22 -0000 [ https://issues.apache.org/jira/browse/REEF-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421687#comment-15421687 ] Sergiy Matusevych commented on REEF-1532: ----------------------------------------- Issue [REEF-1527](https://issues.apache.org/jira/browse/REEF-1527) introduces the new methods (that take {{Time}} objects) and deprecates the old ones (that operate with {{long}} timestamps). This issue ([REEF-1532](https://issues.apache.org/jira/browse/REEF-1532)) should be closed after release 0.16 when we remove the deprecated methods. > Pass Time object instead of numeric timestamp in Timer methods > -------------------------------------------------------------- > > Key: REEF-1532 > URL: https://issues.apache.org/jira/browse/REEF-1532 > Project: REEF > Issue Type: Improvement > Components: REEF-Common > Reporter: Sergiy Matusevych > Assignee: Sergiy Matusevych > Labels: deprecation > > Methods in {{Timer}} interface, e.g. {{Timer.isReady()}} accept long timestamp, but in all contexts where the Timer implementations are used, we operate with Time objects. That leads to awkward chain calls, e.g. > {code:java} > timer.getDuration(event.getTimeStamp()) > {code} > instead of shorter and more readable and type safe > {code:java} > timer.getDuration(event) > {code} > We propose to deprecate methods that take {{long}} timestamp in release 0.16 in favor of parameters of type {{Time}} and remove old methods in teh subsequent release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)