reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Dudoladov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-968) Handle RequiredParameter set to null
Date Tue, 09 Aug 2016 20:26:20 GMT

    [ https://issues.apache.org/jira/browse/REEF-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414179#comment-15414179
] 

Sergey Dudoladov commented on REEF-968:
---------------------------------------


 [~mhkweun] Thanks for considering this issues !  I apologize for the late response.

{quote} And we should change the policy to bind a default value to the RequiredParameter.
{quote}

The original intent was to explore exactly this change in policy. However, now I am not so
sure that silently using the default value is a good policy.

I'll start the discussion on the mailing list.


> Handle RequiredParameter set to null
> ------------------------------------
>
>                 Key: REEF-968
>                 URL: https://issues.apache.org/jira/browse/REEF-968
>             Project: REEF
>          Issue Type: Sub-task
>          Components: Tang
>            Reporter: Sergey Dudoladov
>
> Attempt to set a {{RequiredParameter}}  to null should probably use a default value if
available or throw a meaningful exception.
> To reproduce, see [the comment to REEF-932 | https://issues.apache.org/jira/browse/REEF-932?focusedCommentId=15009618&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15009618]
> I modified that patch to include the default value for 
> {code}
> @NamedParameter(default_value = "abc")
>   class FooStringness implements Name<String> {
>   }
> {code}
>  but that code also throws {{IllegalStateException}}. 
> We probably should use the default value instead and log (a) the warning that the {{RequiredParameter}}
is set to null (b) the default we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message