reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tobin Baker <tdba...@cs.washington.edu>
Subject Re: REEF-968 Handle RequiredParameter set to null
Date Mon, 15 Aug 2016 17:16:37 GMT
As the user who originally found this bug, I agree :) Silently substituting
a default value would have masked a bug in our configuration code.

On Wed, Aug 10, 2016 at 2:13 PM, Markus Weimer <markus@weimo.de> wrote:

> On 2016-08-09 13:35, Dudoladov, Sergey wrote:
>
>> The original intent of REEF-968 was to reset the RequiredParameter to
>> the default value, if the configuration attempts to set the parameter
>> to null.
>>
>> Now I am not so sure that silently using the default value is a good
>> policy, and I think it is better to fail fast with the exception.
>> The relevant code in ConfigurationModule already raises the exception
>> with a meaningful message, so I suggest we close the REEF-968 issue
>> as "won't fix".
>>
>
> +1 If the user willfully sets a parameter to `null` where `null` is not an
> acceptable value, we should raise an exception indeed.
>
> Markus
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message