reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Douglas Service <dsop...@gmail.com>
Subject Re: C# build artifacts causing maven test errors
Date Wed, 03 Aug 2016 02:17:45 GMT
We do not need to add app.config to the list of exceptions as I normally do
not see this issue. This was a one time event which I triggered learning
how to do builds. If I see it again, I will note what causes it.

Doug

On Mon, Aug 1, 2016 at 5:49 PM, Mariia Mykhailova <mamykhai@microsoft.com>
wrote:

> I don't think adding app.config to the list of exceptions from RAT check
> is a good idea. It is a valid file which already exists in lang\cs and can
> be created in other folders in the future, so it should be checked same as
> other project files.
>
> If this case of app.config generation during the build is reproducible, we
> need to look into why it gets generated and fix that.
>
> -Mariia
>
> -----Original Message-----
> From: Douglas Service [mailto:dsopsrc@gmail.com]
> Sent: Monday, August 1, 2016 4:36 PM
> To: dev@reef.apache.org
> Subject: Re: C# build artifacts causing maven test errors
>
> Thanks for the explanation.
>
> On Mon, Aug 1, 2016 at 8:54 AM, Markus Weimer <markus@weimo.de> wrote:
>
> > Hi,
> >
> >
> > On 2016-07-26 18:03, Douglas Service wrote:
> >
> >> The following files get generated during a C# build from powershell
> >>
> >> lang/cs/Org.Apache.REEF.All/app.config
> >> [...]
> >> Too many files with unapproved license: 18 See RAT report in:
> >> C:\code\reef\lang\cs\target\rat.txt
> >>
> >> is this a know issue?
> >>
> >
> > Not in this instance (as Mariia mentioned). However, maybe some
> > background on the nature of that error helps. We strive to keep the
> > code base in an always-releasable state. Beyond the technical aspects
> > of having compiling code that passes tests, this means that we aim to
> > comply with all the licensing hygiene people come to expect from an
> > Apache release. To do so, we rely on the Release Audit Tool (RAT)[0].
> > We run it as part of our maven builds. It checks all files for license
> headers, amongst other things.
> >
> > RAT is configured in `pom.xml` where one can define exceptions for the
> > list of files to be checked. For instance, we exclude build results as
> > well as documentation files. If the above error is reproducible by
> > others, it might make sense to add `app.config` to the exceptions.
> >
> > Markus
> >
> >
> > [0]:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcreadur.apache.org%2frat%2f&data=01%7c01%7cmamykhai%40microsoft.com%7c1a010abde9d54975ac4908d3ba64aed7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=6RIIk4g2IjM4ORegw4apmsunWA5EMH8Wyy2RpezQ%2bZU%3d
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message