Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 912DB200B58 for ; Wed, 27 Jul 2016 09:18:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8FBAE160A6E; Wed, 27 Jul 2016 07:18:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 089E0160A90 for ; Wed, 27 Jul 2016 09:18:23 +0200 (CEST) Received: (qmail 59716 invoked by uid 500); 27 Jul 2016 07:18:21 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 59597 invoked by uid 99); 27 Jul 2016 07:18:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jul 2016 07:18:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 74BBB2C0278 for ; Wed, 27 Jul 2016 07:18:20 +0000 (UTC) Date: Wed, 27 Jul 2016 07:18:20 +0000 (UTC) From: "Ji Eun Lee (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (REEF-967) Handle null in RequiredImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 27 Jul 2016 07:18:24 -0000 [ https://issues.apache.org/jira/browse/REEF-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395166#comment-15395166 ] Ji Eun Lee commented on REEF-967: --------------------------------- [~dss-2009@yandex.ru] I made a PR for this (https://github.com/apache/reef/pull/1079), could you please do a pass? Thanks! > Handle null in RequiredImpl > --------------------------- > > Key: REEF-967 > URL: https://issues.apache.org/jira/browse/REEF-967 > Project: REEF > Issue Type: Sub-task > Components: Tang > Reporter: Sergey Dudoladov > Assignee: Ji Eun Lee > Priority: Minor > > Setting {{RequiredImpl}} to null should throw an informative exception instead of NPE. > To reproduce, in the {{TestConfigurationModule}} set the {{RequiredImpl THE_FOO}} to null: > {code} > String s = null; > MyConfigurationModule.CONF > .set(MyConfigurationModule.THE_FOO, s) > .build(); > {code} > This code raises {{java.lang.NullPointerException}} in {{org.apache.reef.tang.util.ReflectionUtilities.classForName(ReflectionUtilities.java:170)}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)