reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dhruv Mahajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1492) On IMRU recovery: if ResultHandler.Dispose() throws exception, IMRU Driver hangs.
Date Wed, 13 Jul 2016 23:03:20 GMT

    [ https://issues.apache.org/jira/browse/REEF-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375961#comment-15375961
] 

Dhruv Mahajan commented on REEF-1492:
-------------------------------------

{quote}
In case of Dispose() failure the UpdateTaskHost should probably trigger non-recoverable failure,
which in turn triggers Driver failure (right now driver hangs)
{quote}

I think we need to differentiate between two scenarios here. If UpdateHostTask reached DIspose()
call of result handler before it got a Close signal then exception there should trigger non-recoverable
failure. Otherwise, if Close() signal was received from driver, we can make it a recoverable
failure?

> On IMRU recovery: if ResultHandler.Dispose() throws exception, IMRU Driver hangs.
> ---------------------------------------------------------------------------------
>
>                 Key: REEF-1492
>                 URL: https://issues.apache.org/jira/browse/REEF-1492
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF
>            Reporter: Andrey
>              Labels: FT
>
> IMRU scenario:
> - one of the map tasks fails
> - Driver triggers shutdown on all tasks 
> - UpdateTaskHost on shutdown is calling ResultHandler.Dispose()
> - resulthandler (in my case WriteResultHandler) throws exeption because there are no
results (Update function was never executed)
> There are couple questions here:
> - WriteResulthandler should handle [no results] situation more gracefully,  especially
on Dispose() 
> Probably logic of copy file should be moved from Dispose() to HandleResult() function.
> - UpdateTaskHost should handle exceptions from Dispose() call....result handler can be
provided by client, so code can throw.
> In case of Dispose() failure the UpdateTaskHost should probably trigger non-recoverable
failure, which in turn triggers Driver failure  (right now driver  hangs)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message