reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julia (JIRA)" <j...@apache.org>
Subject [jira] [Created] (REEF-1489) Make CancellationToken compulsory in Group Communication APIs.
Date Fri, 08 Jul 2016 01:27:10 GMT
Julia created REEF-1489:
---------------------------

             Summary: Make CancellationToken compulsory in Group Communication APIs. 
                 Key: REEF-1489
                 URL: https://issues.apache.org/jira/browse/REEF-1489
             Project: REEF
          Issue Type: Improvement
            Reporter: Julia


Currently in REEF-1466, we have make the CancellationTokenSource optional in the following
API:
IReduceReceiver<T>
T Reduce(CancellationTokenSource cancellationSource = null)
IReduceSender<T>
void Send(T data, CancellationTokenSource cancellationSource = null);
IScatterReceiver<T>
List<T> Receive(CancellationTokenSource cancellationSource = null);
IOperatorTopology<T>
T ReceiveFromParent(CancellationTokenSource cancellationSource = null);
IList<T> ReceiveListFromParent(CancellationTokenSource cancellationSource = null);
 T ReceiveFromChildren(IReduceFunction<T> reduceFunction, CancellationTokenSource cancellationSource
= null);

If we would like to keep them as optional, we can resolve this JIRA. 
If we would like to enforce the cancellation token, we should remove default value null in
those API and updated all the usages including test cases. 




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message