reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Won Wook SONG (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (REEF-1478) Refactor common components in runtime-local and runtime-standalone
Date Thu, 14 Jul 2016 02:40:20 GMT

    [ https://issues.apache.org/jira/browse/REEF-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376210#comment-15376210
] 

Won Wook SONG edited comment on REEF-1478 at 7/14/16 2:39 AM:
--------------------------------------------------------------

I've looked into the issue, but it seems like I'll have to move _a lot_ more _classes_ than
I expected in order to move the couple of _classes_ that are both used by `local-runtime`
and `standalone-runtime` into the `common-runtime` package, since each of the components in
the `local-runtime` are linked and referenced between each other, and that would result in
moving almost the entire `local-runtime` into `common-runtime`, which doesn't sound reasonable.
Creating a dependency for `common-runtime` to `local-runtime` sounds even more unreasonable,
so maybe the best way currently would be to keep it as-is (with `standalone-runtime` having
dependency to `local-runtime`, since it actually re-uses those classes).
Do you have another idea for the issue?


was (Author: wonook):
I've looked into the issue, but it seems like I'll have to move a lot more _classes_ than
I expected in order to move the couple of _classes_ that are both used by `local-runtime`
and `standalone-runtime` into the `common-runtime` package, since each of the components in
the `local-runtime` are linked and referenced between each other, and that would result in
moving almost the entire `local-runtime` into `common-runtime`, which doesn't sound reasonable.
Creating a dependency for `common-runtime` to `local-runtime` sounds even more unreasonable,
so maybe the best way currently would be to keep it as-is (with `standalone-runtime` having
dependency to `local-runtime`, since it actually re-uses those classes).
Do you have another idea for the issue?

> Refactor common components in runtime-local and runtime-standalone
> ------------------------------------------------------------------
>
>                 Key: REEF-1478
>                 URL: https://issues.apache.org/jira/browse/REEF-1478
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF Runtime Local, REEF Runtime SSH, REEF Runtime YARN
>            Reporter: Won Wook SONG
>            Assignee: Won Wook SONG
>
> Currently, `Runtime-Standalone` depends on `Runtime Local` and `Runtime YARN` on a few
classes since it uses the exact same code from those components. Since these components are
shared between these runtime components, it would be better to refactor these code inside
`reef-common` with appropriate comments for those classes, to manage these shared files and
to prevent dependencies between different runtime components.
> It is also necessary to find a suitable `RootFolder` name for these commonly used classes,
where the results of these runtimes will be saved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message