reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <>
Subject [jira] [Commented] (REEF-1467) Remove the Exceptions class
Date Tue, 05 Jul 2016 17:25:11 GMT


Markus Weimer commented on REEF-1467:

I looked into StyleCop for exception rules, but didn't find any. Are there any tools like
checkstyle for C#, which could help us enforce good exception practices?

> Remove the Exceptions class
> ---------------------------
>                 Key: REEF-1467
>                 URL:
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET
>            Reporter: Markus Weimer
> REEF.NET uses the {{Exceptions}} class in some places to harmonize exception handling.
Namely, using it ensures that exceptions get logged. 
> However, using this class breaks the control flow at the call site, as {{Exceptions.Throw()}}
does not end execution of a method as the {{throw}} keyword does. Further, we have no way
of enforcing its use in libraries we call or even our own code. Hence, we should remove it
and instead:
>   * Develop clear guidelines for Exceptions, like we did in [REEF-864] for REEF/Java.

>   * Figure out how to enforce such guidelines in the build.
>   * Make sure we have an outermost exception handler bound in every process and thread
REEF spawns that logs the exceptions that escape to it.

This message was sent by Atlassian JIRA

View raw message