reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ji Eun Lee (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (REEF-967) Handle null in RequiredImpl
Date Wed, 27 Jul 2016 07:20:20 GMT

    [ https://issues.apache.org/jira/browse/REEF-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395166#comment-15395166
] 

Ji Eun Lee edited comment on REEF-967 at 7/27/16 7:20 AM:
----------------------------------------------------------

[~dss-2009@yandex.ru] I made a PR for this (https://github.com/apache/reef/pull/1079), could
you please do a pass? Thanks!


was (Author: jieunparklee):
[~dss-2009@yandex.ru] I made a PR for this https://github.com/apache/reef/pull/1079, could
you please do a pass? Thanks!

> Handle null in RequiredImpl
> ---------------------------
>
>                 Key: REEF-967
>                 URL: https://issues.apache.org/jira/browse/REEF-967
>             Project: REEF
>          Issue Type: Sub-task
>          Components: Tang
>            Reporter: Sergey Dudoladov
>            Assignee: Ji Eun Lee
>            Priority: Minor
>
>  Setting {{RequiredImpl}} to null should throw an informative exception instead of NPE.

> To reproduce, in the {{TestConfigurationModule}} set the {{RequiredImpl<TestConfigurationModule.Foo>
THE_FOO}} to null:
> {code}
>  String s = null;
>  MyConfigurationModule.CONF
>          .set(MyConfigurationModule.THE_FOO, s)
>          .build();
> {code}
> This code raises {{java.lang.NullPointerException}}  in {{org.apache.reef.tang.util.ReflectionUtilities.classForName(ReflectionUtilities.java:170)}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message