Mailing-List: contact dev-help@reef.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@reef.apache.org
Date: Fri, 24 Jun 2016 15:31:16 +0000 (UTC)
From: "Markus Weimer (JIRA)" <jira@apache.org>
To: dev@reef.apache.org
Message-ID: <JIRA.12981552.1466555060000.22754.1466782276223@Atlassian.JIRA>
In-Reply-To: <JIRA.12981552.1466555060000@Atlassian.JIRA>
References: <JIRA.12981552.1466555060000@Atlassian.JIRA> <JIRA.12981552.1466555060790@arcas>
Subject: [jira] [Commented] (REEF-1466) Cancel the blocking message reading
 and close the task properly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 24 Jun 2016 15:31:18 -0000


    [ https://issues.apache.org/jira/browse/REEF-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348429#comment-15348429 ] 

Markus Weimer commented on REEF-1466:
-------------------------------------

I don't know :) Which APIs do you intend to expand with the optional parameter?

> Cancel the blocking message reading and close the task properly
> ---------------------------------------------------------------
>
>                 Key: REEF-1466
>                 URL: https://issues.apache.org/jira/browse/REEF-1466
>             Project: REEF
>          Issue Type: Task
>            Reporter: Julia
>              Labels: FT
>
> Currently when driver sends an event to kill a task, in IMRU task close handler, we set a flag for the Call() method to return from next iteration. If the Call() method stuck in reading messages, we throw IMRUTaskSystemException so that for the IMRU driver to receive IFailedTask. After the drive killed all the tasks, the drive will resubmit tasks if the system is recoverable. 
> In REEF-1447, the proposed solution for exceptions throw from task close handler is to fail the Evaluator. With the current IMRU task close handler, this would make all evaluators fail after the tasks are killed by driver. If we want to treat the exception in close handler as FailedEvaluator, we must gracefully handle the task close event instead of throw an exception. 
> I would like to re-propose the cancellation token solution we discussed before. Pass a cancellation token from task all the way to the NodeStruct.GetData(). When the task close handler is called, cancel the cancellation token for the task to return properly. 
> This will involve some GC/Network method signature changes, some are internal some are public. 
> Let me know if you have any concerns about this solution. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)