Return-Path: <dev-return-11171-archive-asf-public=cust-asf.ponee.io@reef.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 866802009EE
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 18 May 2016 17:33:14 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 84EEB160A15; Wed, 18 May 2016 15:33:14 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 003321609B0
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 18 May 2016 17:33:13 +0200 (CEST)
Received: (qmail 54827 invoked by uid 500); 18 May 2016 15:33:13 -0000
Mailing-List: contact dev-help@reef.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@reef.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@reef.apache.org>
List-Post: <mailto:dev@reef.apache.org>
List-Id: <dev.reef.apache.org>
Reply-To: dev@reef.apache.org
Delivered-To: mailing list dev@reef.apache.org
Received: (qmail 54808 invoked by uid 99); 18 May 2016 15:33:13 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 May 2016 15:33:13 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id DFF892C033A
	for <dev@reef.apache.org>; Wed, 18 May 2016 15:33:12 +0000 (UTC)
Date: Wed, 18 May 2016 15:33:12 +0000 (UTC)
From: "Markus Weimer (JIRA)" <jira@apache.org>
To: dev@reef.apache.org
Message-ID: <JIRA.12970511.1463513799000.224686.1463585592913@Atlassian.JIRA>
In-Reply-To: <JIRA.12970511.1463513799000@Atlassian.JIRA>
References: <JIRA.12970511.1463513799000@Atlassian.JIRA> <JIRA.12970511.1463513799220@arcas>
Subject: [jira] [Commented] (REEF-1392) Adding IObserver<ICloseEvent> for
 IMRU tasks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 18 May 2016 15:33:14 -0000


    [ https://issues.apache.org/jira/browse/REEF-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289157#comment-15289157 ] 

Markus Weimer commented on REEF-1392:
-------------------------------------

{quote}
When they receive ICloseEvent, it will verify if the closing event is send from driver based on the message in the event, then trow IMRUTaskException with a define message to inform the driver it is closed.
{quote}

This seems problematic. Why throw an exception here, if it is a supported feature? Wouldn't we want the tasks to finish their current iteration and then terminate them?

> Adding IObserver<ICloseEvent> for IMRU tasks
> --------------------------------------------
>
>                 Key: REEF-1392
>                 URL: https://issues.apache.org/jira/browse/REEF-1392
>             Project: REEF
>          Issue Type: Task
>            Reporter: Julia
>            Assignee: Julia
>              Labels: FT
>
> For fault tolerant, IMRU tasks, MapTaskHost and UpdateTaskHost should implement  IObserver<ICloseEvent>. When they receive ICloseEvent,  it will verify if the closing event is send from driver based on the message in the event, then trow IMRUTaskException with a define message to inform the driver it is closed. 
> The  change should be backward compatible. If the the IMRU tasks are not bound to the task configuration for  TaskConfiguration.OnClose, the event won't be received. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)