Mailing-List: contact dev-help@reef.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@reef.apache.org
MIME-Version: 1.0
In-Reply-To: <573CA8AB.9050808@weimo.de>
References: <SN2PR03MB2381F644DC2159C4BD627B2090480@SN2PR03MB2381.namprd03.prod.outlook.com>
 <BN3PR03MB2179BDCB4373993D1D20C1EED2480@BN3PR03MB2179.namprd03.prod.outlook.com>
 <CAO2Ppvv4G_sMVdEYc7g3G0RwC4Xn0=eAthx0nFs=Ltkg_mShSw@mail.gmail.com>
 <CA+4sW8iF5FVczenHs0qkOYtP2iK97BFr2DT3ivo9OoPwyNOCMQ@mail.gmail.com>
 <CAOFpRGDMCenRwmP9XZizcoAUkj1DsSnQepo=Rzb+hfyOU5eJ7g@mail.gmail.com>
 <CAHzzxZSxaVA-xyRg2w7US=vzzvY+Qo03psXmw72=xJphJ1gdkg@mail.gmail.com> <573CA8AB.9050808@weimo.de>
From: Andrew Chung <afchung90@gmail.com>
Date: Wed, 18 May 2016 11:03:48 -0700
Message-ID: <CAHzzxZTzDPOiR=HkGwtfkP4OFOEUmho1qbJe83PQKpNmY=JzUA@mail.gmail.com>
Subject: Re: Test failure in master
To: dev@reef.apache.org
Content-Type: multipart/alternative; boundary=001a1143f53a48d88d053321b01a
archived-at: Wed, 18 May 2016 18:04:34 -0000

--001a1143f53a48d88d053321b01a
Content-Type: text/plain; charset=UTF-8

Hi Markus,

Yes, however, note that the documentation[0] mentions that
`getActiveCount()` returns the *approximate* number of threads that are
active. It seems that there are people that have already run into trouble
with using it[1].
To solve this, I'm using `getInMeter().getCount() -
getOutMeter().getCount()` in `ThreadPoolStage` instead, and putting
`afterOnNext` into the `finally` block in the `run` method of
`executor.submit`.

Thanks,
Andrew

[0]:
http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html#getActiveCount%28%29
[1]:
http://stackoverflow.com/questions/7271541/threadpoolexecutors-getactivecount/7271685

On Wed, May 18, 2016 at 10:38 AM, Markus Weimer <markus@weimo.de> wrote:

> Hi,
>
> our idless check boils down to checking whether or not any thread in
> `org.apache.reef.wake.impl.ThreadPoolStage` is still active. That calses is
> based on a `ThreadPoolExecutor`, which has a convenient method
> `.getActiveCount()`. Maybe we need to expose that method in some elegant
> way?
>
> Markus
>

--001a1143f53a48d88d053321b01a--