reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mariia Mykhailova <mamyk...@microsoft.com>
Subject RE: Default level of logging
Date Fri, 06 May 2016 23:00:54 GMT
We've updated "default log level" as defined in Logger.cs, but in other places we still use
Verbose as default (CustomTraceLevel.cs and DriverBridgeConfigurationOptions. cs). So, for
example, loggers created in tests themselves run with Info level, but loggers created in evaluators
created in tests run with Verbose level.

Should we unify default log level across all places it is used?

-Mariia

-----Original Message-----
From: Mariia Mykhailova [mailto:mamykhai@microsoft.com] 
Sent: Tuesday, April 12, 2016 11:30 AM
To: dev@reef.apache.org
Subject: RE: Default level of logging

Thank you all for unanimous support :-) The change is in as part of REEF-1331

-Mariia

-----Original Message-----
From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com]
Sent: Monday, April 11, 2016 3:12 PM
To: dev@reef.apache.org
Subject: RE: Default level of logging

+1

-----Original Message-----
From: Dongjoon Hyun [mailto:dongjoon@apache.org]
Sent: Monday, April 11, 2016 2:33 PM
To: dev@reef.apache.org
Subject: Re: Default level of logging

+1

On Mon, Apr 11, 2016 at 2:30 PM, Andrew Chung <afchung90@gmail.com> wrote:

> +1
>
> On Mon, Apr 11, 2016 at 2:27 PM, Markus Weimer <markus@weimo.de> wrote:
> > +1 on raising the default log level.
> >
> >
> > On 4/11/2016 2:20 PM, Mariia Mykhailova wrote:
> >>
> >> Hi,
> >>
> >> Currently our logging level is set to VERBOSE by default. This 
> >> produces
> a
> >> huge amount of logs, which, judging from their log level, are not
> necessary
> >> except for debug sessions. For example, an average AppVeyor run
> produces 15k
> >> lines of log (which includes only logs written by tests, not by 
> >> drivers
> and
> >> evaluators invoked), of which over 6k are verbose logs.
> >>
> >> Increasing default value for _customLevel in Logger.cs to Info 
> >> doesn't break any tests (which I was concerned about, since they 
> >> rely on reading logs). Does anybody have concerns about 
> >> consequences of increasing this value for other parts of REEF? If 
> >> not, I'd like to increase it, and
> have any
> >> separate modules/tests which really require VERBOSE level set it
> explicitly
> >> for themselves.
> >>
> >> -Mariia
> >>
> >
>
Mime
View raw message