Return-Path: X-Original-To: apmail-reef-dev-archive@minotaur.apache.org Delivered-To: apmail-reef-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97B361856D for ; Thu, 28 Apr 2016 20:00:16 +0000 (UTC) Received: (qmail 95679 invoked by uid 500); 28 Apr 2016 20:00:16 -0000 Delivered-To: apmail-reef-dev-archive@reef.apache.org Received: (qmail 95645 invoked by uid 500); 28 Apr 2016 20:00:16 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 95378 invoked by uid 99); 28 Apr 2016 20:00:16 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2016 20:00:16 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D6EEA2C1F68 for ; Thu, 28 Apr 2016 20:00:15 +0000 (UTC) Date: Thu, 28 Apr 2016 20:00:15 +0000 (UTC) From: "Dhruv Mahajan (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (REEF-1361) IFileDeSerializer does not have a Dispose function MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/REEF-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262860#comment-15262860 ] Dhruv Mahajan commented on REEF-1361: ------------------------------------- So these files are the raw files that were downloaded from remote. Now my upstream has a more efficient format and if the file is in that format the subsequent iterations over data from disk wud be efficient. So here is what I want to do: In DeSerializer I read these raw files and convert them in to another temp file in the format needed by upstream. Now when we are exiting the IInputPartition this temp file needs to be disposed also along with raw files. Does that make sense? > IFileDeSerializer does not have a Dispose function > -------------------------------------------------- > > Key: REEF-1361 > URL: https://issues.apache.org/jira/browse/REEF-1361 > Project: REEF > Issue Type: Improvement > Components: REEF.NET IO > Environment: C# > Reporter: Dhruv Mahajan > > Currently {{IFileDeserializer}} does not inherit {{IDisposable}} class to dispose unmanaged resources like files. This becomes necessary in case it decides to add some disk based cache and writes a cache to the disk at some temporary location. This cache then needs to be deleted once {{IInputPartition}} is being disposed by calling the {{IFileDeserializer.Dispose()}} in {{IInputPartition.Dispose()}}. > The aim of this JIRA is to introduce the dispose functionality in {{IFileDeserializer}} and modify {{FileSystemInputPartition}} to use it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)