Mailing-List: contact dev-help@reef.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@reef.apache.org
Date: Mon, 25 Apr 2016 20:02:12 +0000 (UTC)
From: "Markus Weimer (JIRA)" <jira@apache.org>
To: dev@reef.apache.org
Message-ID: <JIRA.12962055.1461447642000.27396.1461614532848@Atlassian.JIRA>
In-Reply-To: <JIRA.12962055.1461447642000@Atlassian.JIRA>
References: <JIRA.12962055.1461447642000@Atlassian.JIRA>
 <JIRA.12962055.1461447642842@arcas>
Subject: [jira] [Commented] (REEF-1356) Create MultiRuntime Configuration
 Builder for c#
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/REEF-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256939#comment-15256939 ] 

Markus Weimer commented on REEF-1356:
-------------------------------------

In {{AddRuntime}}, what is the {{configuration}}? Is this the Driver-side of the runtime configuration? For Java or C#? Also, why is it optional?

In {{SetSubmissionRuntime}}, the {{configuration}} is the client side configuration? Why would we need this? I'd expect that I could use whichever client to submit a Driver which happens to use the multi-runtime. To that end, maybe rename the new interface {{MultiRuntimeDriverConfigurationBuilder}}?

On the name itself: Does it actually {{.Build()}} a {{IConfiguration}}? Otherwise {{ConfigurationBuilder}} is a misleading suffix for the name.

> Create MultiRuntime Configuration Builder for c#
> ------------------------------------------------
>
>                 Key: REEF-1356
>                 URL: https://issues.apache.org/jira/browse/REEF-1356
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF
>            Reporter: Boris Shulman
>            Assignee: Boris Shulman
>
> The purpose of this Jira is creating a mechanism for MultiRuntime Job Submission.
> MultiRuntimeConfiguration builder will expose the following interface:
> {code}
> MultiRuntimeConfigurationBuilder
> {
>         public MultiRuntimeConfigurationBuilder AddRuntime(
>                  RuntimeName runtimeName, 
>                  IConfiguration configuration = null);
>         public MultiRuntimeConfigurationBuilder SetDefaultRuntime(
>                   RuntimeName runtimeName);
>         public MultiRuntimeConfigurationBuilder SetSubmissionRuntime(
>                   SubmissionRuntimeName runtimeName, 
>                  IConfiguration configuration);
> }
> {code}
> In addition each supported runtime/submission runtime will provide an execution/submission runtime configuration builder. As not each runtime requires additional configuration for execution runtime (Yarn for example), this parameter is optional on the interface.
> In order to add additional execution runtime we will need to create a execution runtime builder,  add it to the avro schema and alter the bootstrapping code to support it.
> Adding new submission runtime is a more complex process as new bootstrap code is required.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)