Return-Path: X-Original-To: apmail-reef-dev-archive@minotaur.apache.org Delivered-To: apmail-reef-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3B21C19FC3 for ; Fri, 22 Apr 2016 22:17:13 +0000 (UTC) Received: (qmail 24946 invoked by uid 500); 22 Apr 2016 22:17:13 -0000 Delivered-To: apmail-reef-dev-archive@reef.apache.org Received: (qmail 24914 invoked by uid 500); 22 Apr 2016 22:17:13 -0000 Mailing-List: contact dev-help@reef.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@reef.apache.org Delivered-To: mailing list dev@reef.apache.org Received: (qmail 24903 invoked by uid 99); 22 Apr 2016 22:17:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 22:17:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D40942C14F7 for ; Fri, 22 Apr 2016 22:17:12 +0000 (UTC) Date: Fri, 22 Apr 2016 22:17:12 +0000 (UTC) From: "Mariia Mykhailova (JIRA)" To: dev@reef.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (REEF-1352) Add exception classes for integration tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/REEF-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254794#comment-15254794 ] Mariia Mykhailova commented on REEF-1352: ----------------------------------------- After that, for example, {{PoisonException}} would be inherited from {{EvaluatorSideExpectedException}}? > Add exception classes for integration tests > ------------------------------------------- > > Key: REEF-1352 > URL: https://issues.apache.org/jira/browse/REEF-1352 > Project: REEF > Issue Type: New Feature > Components: REEF.NET > Reporter: Markus Weimer > > We currently rely on ad-hoc exception messages in the REEF.NET integration tests. Once the work to properly propagate exceptions from Evaluator to Driver to Client is done, we can do better than that. Namely, I propose to introduce a set of new exception types in the {{Org.Apache.REEF.Tests.Exceptions}} namespace: > *Expected Exceptions* > * {{DriverSideExpectedException}}: The test expects this exception and will check its contents (cause, message) to decide whether the test passes. > * {{EvaluatorSideExpectedException}}: Same, but on the driver side. > *Exceptions indicating test failure* > * {{DriverSideTestFailure}}: The test failed because of a check on the Driver side. > * {{EvaluatorSideTestFailure}}: Same, but on the driver side. > *Exceptions indicating bugs in untested parts of REEF* > * {{DriverSideSystemException}}: The test encountered unexpected behavior that it didn't test for. In other words: A change broke the test. > * {{EvaluatorSideSystemException}}: Same, but on the driver side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)