Mailing-List: contact dev-help@reef.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@reef.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAHzzxZSyTVj7JJUMBbdOxjwRspg8L0UPDtwnNDiLzQ1b8iTbJQ@mail.gmail.com>
References: 
 <CAO2PpvvJ6YPjSmDwXhKkuQOcsYprzJYd79m5EdCdk4twJgzODw@mail.gmail.com>
	<SN2PR03MB23819E02819C507D4168364D90910@SN2PR03MB2381.namprd03.prod.outlook.com>
	<CAHzzxZSyTVj7JJUMBbdOxjwRspg8L0UPDtwnNDiLzQ1b8iTbJQ@mail.gmail.com>
Date: Fri, 8 Apr 2016 11:29:05 -0700
Message-ID: 
 <CAO2Ppvtcn8pHef1ym4A8ikSabfVJU3K9eb3cMAw2a8qigmr-Rg@mail.gmail.com>
Subject: Re: ICompletedTask semantics
From: Dhruv Mahajan <dhruv.mahajan@gmail.com>
To: dev@reef.apache.org
Content-Type: multipart/alternative; boundary=94eb2c0a79cab3193c052ffd5e11

--94eb2c0a79cab3193c052ffd5e11
Content-Type: text/plain; charset=UTF-8

I feel if dispose fails, Task should still be termed as completed and
failure should be ignored. Can we think of scenarios in which this logic is
bad?

Dhruv

On Fri, Apr 8, 2016 at 11:18 AM, Andrew Chung <afchung90@gmail.com> wrote:

> Hi Dhruv,
>
> Interesting question. There might actually be a race condition here
> (somewhat, since I'm not sure if we count the `Dispose` call as part
> of the Task), given that `Dispose` is actually called *after* setting
> the Task status to `Completed`, and the Task thread locks on a
> separate object than the Heartbeat thread. Only the Task status set
> operation is atomic. Thus, if the Heartbeat thread gets the Task
> status and sends the message to the Driver prior to the Dispose is
> called, it is possible that Task.Dispose is not yet called before the
> Driver receives the Task completion message.
>
> Given that we haven't defined a particular order for this sequence of
> events, perhaps we should change the behavior to what Dhruv expects?
>
> Another thing to consider is whether we count `Dispose` as part of the
> Task. e.g. If Dispose fails, do we count the Task as failed (Somewhat
> dangerous, since many users don't implement Dispose on their Tasks)?
> Do we only count the Task as Completed after the Dispose is done? What
> do you think?
>
> Thanks,
> Andrew
>
> On Fri, Apr 8, 2016 at 10:26 AM, Julia Wang (QIUHE)
> <Qiuhe.Wang@microsoft.com> wrote:
> > It has been disposed I believe.
> >
> > -----Original Message-----
> > From: Dhruv Mahajan [mailto:dhruv.mahajan@gmail.com]
> > Sent: Friday, April 8, 2016 10:07 AM
> > To: dev@reef.apache.org
> > Subject: ICompletedTask semantics
> >
> > Hi
> >
> > I have a question regarding the semantics of ICompletedTask. Does this
> mean that Dispose on the Task has already been called or it will be called
> after driver acks. this message? I feel it is former but just wanted to
> verify.
> >
> > Dhruv
>

--94eb2c0a79cab3193c052ffd5e11--