reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Weimer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (REEF-1372) Create new named parameters for IClock
Date Fri, 29 Apr 2016 18:25:12 GMT

    [ https://issues.apache.org/jira/browse/REEF-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264481#comment-15264481
] 

Markus Weimer edited comment on REEF-1372 at 4/29/16 6:24 PM:
--------------------------------------------------------------

Thanks! I will try scoping it for the whole constructor. The warning isn't really needed as
we have {{//TODO}} markers and JIRAs filed. Adding warnings creates a false impression for
people compiling REEF for the first time. But maybe I am just overly optimistic on our ability
to follow up on {{//TODO}} markers :)


was (Author: markus.weimer):
Thanks! I will try scoping it for the whole constructor. The warning isn't really needed as
we have {{//TODO}} markers and JIRAs filed. Adding warnings creates a false impression for
people compiling REEF for the first time. But maybe I am just overly optimistic on our ability
to follow up on {{//TODO}}s :)

> Create new named parameters for IClock
> --------------------------------------
>
>                 Key: REEF-1372
>                 URL: https://issues.apache.org/jira/browse/REEF-1372
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET
>            Reporter: Markus Weimer
>            Assignee: Markus Weimer
>
> {{IClock}} is an abstract class, but should be an interface. The one reason we can't
change that right now is that it also contains all the named parameters for it. We should
create new named parameters and deprecate the ones in {{IClock}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message