reef-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariia Mykhailova (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (REEF-1372) Create new named parameters for IClock
Date Fri, 29 Apr 2016 18:18:12 GMT

    [ https://issues.apache.org/jira/browse/REEF-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264475#comment-15264475
] 

Mariia Mykhailova commented on REEF-1372:
-----------------------------------------

Most likely StyleCop treats {{pragma}}s placed like this as part of next parameter. I'd try
to either remove {{pragma}}s altogether (I'm fine with getting obsolete warnings, as they
remind us to actually remove the code once we can) or to increase their scope to include the
whole constructor, not just a subset of parameters.

> Create new named parameters for IClock
> --------------------------------------
>
>                 Key: REEF-1372
>                 URL: https://issues.apache.org/jira/browse/REEF-1372
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET
>            Reporter: Markus Weimer
>            Assignee: Markus Weimer
>
> {{IClock}} is an abstract class, but should be an interface. The one reason we can't
change that right now is that it also contains all the named parameters for it. We should
create new named parameters and deprecate the ones in {{IClock}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message